----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56634/#review165453 -----------------------------------------------------------
Ship it! Ship It! - Suma Shivaprasad On Feb. 14, 2017, 2:20 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56634/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2017, 2:20 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1522 > https://issues.apache.org/jira/browse/ATLAS-1522 > > > Repository: atlas > > > Description > ------- > > In an entity instance, attribute values that refer to other entities (like > hive_table.columns attribute that refers to an array of hive_column objects) > will hold value of type AtlasObjectId, instead of entities themselves. This > helps to keep the data model simple and avoid any potential circular > references in an entity value. With this design, the equivalent of > Referencable instance (from earlier versions) will be an instance of > AtlasEntityWithExtInfo - which holds details of an entity (like hive_table) > along with all entities referenced by this entity (like hive_columns, > hive_db, hive_storagedesc), in a separate field named obj.referredEntities. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java adffee7 > intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 77f5d80 > intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 1bfdf77 > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java b537295 > intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 7624bc1 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 232356a > intg/src/main/java/org/apache/atlas/type/AtlasType.java de71d11 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > cbc91f5 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java > 2e9393e > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java > 99f074b > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > ff13ea5 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > cb8636b > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > 847e5fe > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java > 9d01357 > webapp/src/main/java/org/apache/atlas/util/RestUtils.java 08dac8a > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java > 7c3f536 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java > e87956f > > Diff: https://reviews.apache.org/r/56634/diff/ > > > Testing > ------- > > Verified that all unit tests pass > > > Thanks, > > Madhan Neethiraj > >
