Re: Review Request 56860: ATLAS-1552 auto update of inverse references in V2 code path

2017-03-01 Thread David Kantor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56860/ --- (Updated March 1, 2017, 2:18 p.m.) Review request for atlas. Changes ---

Re: Review Request 56860: ATLAS-1552 auto update of inverse references in V2 code path

2017-03-01 Thread David Radley
> On Feb. 27, 2017, 5:27 p.m., David Radley wrote: > > I have done a little testing at V2 to model a parent children hierarchy > > that we would need to define a Glossary (see Jira 1410) > > > > I define types EntityA with a children 1 to many optional attribute to > > EntityB. EntityB has

Re: Review Request 56860: ATLAS-1552 auto update of inverse references in V2 code path

2017-02-27 Thread David Kantor
> On Feb. 27, 2017, 5:27 p.m., David Radley wrote: > > I have done a little testing at V2 to model a parent children hierarchy > > that we would need to define a Glossary (see Jira 1410) > > > > I define types EntityA with a children 1 to many optional attribute to > > EntityB. EntityB has

Re: Review Request 56860: ATLAS-1552 auto update of inverse references in V2 code path

2017-02-27 Thread David Radley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56860/#review166897 --- I have done a little testing at V2 to model a parent children

Re: Review Request 56860: ATLAS-1552 auto update of inverse references in V2 code path

2017-02-24 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56860/#review166719 --- Ship it! Ship It! - Madhan Neethiraj On Feb. 24, 2017, 3

Re: Review Request 56860: ATLAS-1552 auto update of inverse references in V2 code path

2017-02-24 Thread David Kantor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56860/ --- (Updated Feb. 24, 2017, 3 p.m.) Review request for atlas. Changes ---

Re: Review Request 56860: ATLAS-1552 auto update of inverse references in V2 code path

2017-02-24 Thread David Kantor
> On Feb. 23, 2017, 7:14 a.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java, > > line 333 > > > > > > It might be useful to add a method in

Re: Review Request 56860: ATLAS-1552 auto update of inverse references in V2 code path

2017-02-24 Thread David Kantor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56860/ --- (Updated Feb. 24, 2017, 2:25 p.m.) Review request for atlas. Changes ---

Re: Review Request 56860: ATLAS-1552 auto update of inverse references in V2 code path

2017-02-23 Thread Suma Shivaprasad
> On Feb. 23, 2017, 7:23 p.m., Suma Shivaprasad wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java, > > line 330 > > > > > > handle map case as well? > > David

Re: Review Request 56860: ATLAS-1552 auto update of inverse references in V2 code path

2017-02-23 Thread David Kantor
> On Feb. 23, 2017, 7:23 p.m., Suma Shivaprasad wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java, > > line 330 > > > > > > handle map case as well? Maps are

Re: Review Request 56860: ATLAS-1552 auto update of inverse references in V2 code path

2017-02-23 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56860/#review166552 ---

Re: Review Request 56860: ATLAS-1552 auto update of inverse references in V2 code path

2017-02-23 Thread Madhan Neethiraj
> On Feb. 23, 2017, 7:14 a.m., Madhan Neethiraj wrote: > > Consider the following scenario: > > - create hive_table 'employee' > > - create hive_column 'name'; set attribute 'table' to 'employee' table > > created above > > - now 'employee.columns' attribute lists 'name' - good! > > - create

Re: Review Request 56860: ATLAS-1552 auto update of inverse references in V2 code path

2017-02-23 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56860/#review166543 --- Ship it! Ship It! - Madhan Neethiraj On Feb. 22, 2017,

Re: Review Request 56860: ATLAS-1552 auto update of inverse references in V2 code path

2017-02-23 Thread David Kantor
> On Feb. 23, 2017, 7:14 a.m., Madhan Neethiraj wrote: > > Consider the following scenario: > > - create hive_table 'employee' > > - create hive_column 'name'; set attribute 'table' to 'employee' table > > created above > > - now 'employee.columns' attribute lists 'name' - good! > > - create

Re: Review Request 56860: ATLAS-1552 auto update of inverse references in V2 code path

2017-02-22 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56860/#review166483 --- Consider the following scenario: - create hive_table 'employee' -

Review Request 56860: ATLAS-1552 auto update of inverse references in V2 code path

2017-02-22 Thread David Kantor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56860/ --- Review request for atlas. Bugs: ATLAS-1552