Re: Review Request 58803: ATLAS-1390: IBM graph implementation

2017-05-30 Thread Graham Wallis
> On May 10, 2017, 2:28 p.m., Graham Wallis wrote: > > I managed to get this to build and ran it against an IBM Graph instance. > > But there are a number of things that needed changes/workarounds to get it > > working: > > > > 1. The atlas-graphdb-ibm-graph build relies on the java-8 build pr

Re: Review Request 58803: ATLAS-1390: IBM graph implementation

2017-05-25 Thread Apoorv Naik
> On May 10, 2017, 2:28 p.m., Graham Wallis wrote: > > I managed to get this to build and ran it against an IBM Graph instance. > > But there are a number of things that needed changes/workarounds to get it > > working: > > > > 1. The atlas-graphdb-ibm-graph build relies on the java-8 build pr

Re: Review Request 58803: ATLAS-1390: IBM graph implementation

2017-05-10 Thread Apoorv Naik
> On May 10, 2017, 2:28 p.m., Graham Wallis wrote: > > I managed to get this to build and ran it against an IBM Graph instance. > > But there are a number of things that needed changes/workarounds to get it > > working: > > > > 1. The atlas-graphdb-ibm-graph build relies on the java-8 build pr

Re: Review Request 58803: ATLAS-1390: IBM graph implementation

2017-05-10 Thread Graham Wallis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58803/#review174476 --- I managed to get this to build and ran it against an IBM Graph ins

Re: Review Request 58803: ATLAS-1390: IBM graph implementation

2017-05-05 Thread Graham Wallis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58803/#review174038 --- Hi Apoorv, Thanks for rebasing - it's definitely better than befo

Re: Review Request 58803: ATLAS-1390: IBM graph implementation

2017-05-04 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58803/ --- (Updated May 4, 2017, 4:35 p.m.) Review request for atlas, David Radley, David

Re: Review Request 58803: ATLAS-1390: IBM graph implementation

2017-05-04 Thread Apoorv Naik
> On May 4, 2017, 4:25 p.m., Graham Wallis wrote: > > Hi Apoorv, > > I tried to pull this patch in but got conflicts against the current master. > > > > Initially there were a few warnings about spaces and tabs, but these are > > followed by two reported conflicts: > > > > C:\dev\atlas\incubat

Re: Review Request 58803: ATLAS-1390: IBM graph implementation

2017-05-04 Thread Graham Wallis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58803/#review173920 --- repository/src/main/java/org/apache/atlas/discovery/EntityDiscove

Re: Review Request 58803: ATLAS-1390: IBM graph implementation

2017-05-04 Thread Graham Wallis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58803/#review173918 --- Hi Apoorv, I tried to pull this patch in but got conflicts against

Re: Review Request 58803: ATLAS-1390: IBM graph implementation

2017-05-04 Thread David Radley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58803/#review173891 --- I have discussed with Graham Wallis, he intends to perform this re

Review Request 58803: ATLAS-1390: IBM graph implementation

2017-04-27 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58803/ --- Review request for atlas. Repository: atlas Description --- See https://