Jenkins build is back to normal : aurora-packaging-nightly #138

See

Re: Commits without reviews

Thinking more about what Joshua said above, i think we could also have a valuable discussion about making more frequent use of "to be reviewed" (a.k.a. tbr) reviews that we commit before receiving review feedback. Anybody have thoughts on that? On Thu, Dec 24, 2015 at 10:25 AM, Jie Yu wrote: > +

Re: Commits without reviews

+1 Flying by. Mesos allows small commits without reviews and it works well in practice. - Jie On Wed, Dec 23, 2015 at 1:48 PM, Bill Farner wrote: > All, > > Over the past few days, i have made several commits to the repository > without code review. Our convention has historically been to per

Re: Commits without reviews

This is where i look towards allowing committers to exercise judgement. IMHO for commits like the ones above, a review is extra noise for everyone. I suppose my position is that i favor simplifying commits over simplifying comments. On Thu, Dec 24, 2015 at 9:12 AM, Joshua Cohen wrote: > It coul

Re: Commits without reviews

It could be, I just think it's easier to comment on a reviewboard than it is a commits@ email. On Thu, Dec 24, 2015 at 10:29 AM, Bill Farner wrote: > Can that be handled by subscribing to commits@? > > On Thursday, December 24, 2015, Joshua Cohen wrote: > > > I'm generally ok with this. Just cu

Re: Commits without reviews

Can that be handled by subscribing to commits@? On Thursday, December 24, 2015, Joshua Cohen wrote: > I'm generally ok with this. Just curious: what do you think about maybe > posting a review and then committing it right away in these cases though? A > bit noisy on the reviews@ list, but at lea

Re: Commits without reviews

I'm generally ok with this. Just curious: what do you think about maybe posting a review and then committing it right away in these cases though? A bit noisy on the reviews@ list, but at least it'd give people a chance to peruse/comment as they see fit (with the assumption that any comments would b