[jira] [Commented] (AVRO-1270) Emit default values from resolved reader during schema evolution/projection

2013-05-07 Thread Zhenghua Chen (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650647#comment-13650647 ] Zhenghua Chen commented on AVRO-1270: - It seems that C++ implemenation has the same pro

[jira] [Commented] (AVRO-1285) Avro schema compile does not support circular reference

2013-05-07 Thread Doug Houck (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650671#comment-13650671 ] Doug Houck commented on AVRO-1285: -- Hey Doug, the three cases sited appear to apply to ext

Avro-C: namespace lookup and inherited namespaces

2013-05-07 Thread Ben Walsh
Hi It seems that the C version of Avro doesn't resolve fully-qualified type names, and it doesn't understand inherited namespaces. For example this doesn't work: {"type": "record", "namespace": "x", "name": "Y", "fields": [ {"name": "e", "type": {"type": "record", "name": "Z", "fields": [

Re: Avro-C: namespace lookup and inherited namespaces

2013-05-07 Thread Bruce Mitchener
On May 7, 2013, at 5:17 PM, Ben Walsh wrote: > > Hi > > It seems that the C version of Avro doesn't resolve fully-qualified type > names, and it doesn't understand inherited namespaces. > > For example this doesn't work: > > {"type": "record", "namespace": "x", "name": "Y", "fields": [ > {"

[jira] [Commented] (AVRO-1285) Avro schema compile does not support circular reference

2013-05-07 Thread Doug Houck (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650710#comment-13650710 ] Doug Houck commented on AVRO-1285: -- Thinking a bit more about this request I am not su

[jira] [Created] (AVRO-1324) Avro-C: namespace lookup and inherited namespaces

2013-05-07 Thread Ben Walsh (JIRA)
Ben Walsh created AVRO-1324: --- Summary: Avro-C: namespace lookup and inherited namespaces Key: AVRO-1324 URL: https://issues.apache.org/jira/browse/AVRO-1324 Project: Avro Issue Type: Improvement

[jira] [Updated] (AVRO-1324) Avro-C: namespace lookup and inherited namespaces

2013-05-07 Thread Ben Walsh (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Walsh updated AVRO-1324: Attachment: namespace.patch This patch also adds more testing to test_avro_schema.c so that it does a read-

[jira] [Updated] (AVRO-1324) Avro-C: namespace lookup and inherited namespaces

2013-05-07 Thread Ben Walsh (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Walsh updated AVRO-1324: Priority: Minor (was: Major) > Avro-C: namespace lookup and inherited namespaces >

[jira] [Updated] (AVRO-1324) Avro-C: namespace lookup and inherited namespaces

2013-05-07 Thread Ben Walsh (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Walsh updated AVRO-1324: Priority: Major (was: Minor) > Avro-C: namespace lookup and inherited namespaces >

[jira] [Updated] (AVRO-1324) Avro-C: namespace lookup and inherited namespaces

2013-05-07 Thread Ben Walsh (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Walsh updated AVRO-1324: Priority: Minor (was: Major) > Avro-C: namespace lookup and inherited namespaces >

[jira] [Commented] (AVRO-1316) IDL code-generation generates too-long literals for very large schemas

2013-05-07 Thread Micah Huff (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650816#comment-13650816 ] Micah Huff commented on AVRO-1316: -- [~cutting]--That looks good. I ran our code through yo

[jira] [Commented] (AVRO-635) ruby fully-qualified namespace mixed with unqualified breaks

2013-05-07 Thread Martin Kleppmann (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650822#comment-13650822 ] Martin Kleppmann commented on AVRO-635: --- I believe this was fixed in AVRO-1272. Could

Re: Avro-C: namespace lookup and inherited namespaces

2013-05-07 Thread Martin Kleppmann
FWIW, I think the Ruby bug was fixed here: https://issues.apache.org/jira/browse/AVRO-1272 — take a look at the patch, perhaps you can adopt a similar approach in the C implementation (I don't know how similar the code is though, so it may be irrelevant). Martin On 7 May 2013 02:30, Bruce Mitche

[jira] [Commented] (AVRO-1320) Java: Trevni incorrectly reads specific enums.

2013-05-07 Thread Bernd Fondermann (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650880#comment-13650880 ] Bernd Fondermann commented on AVRO-1320: the patch itself works, but does not resol

Re: Reading nested specific type

2013-05-07 Thread Bernd Fondermann
On Tue, May 7, 2013 at 7:26 AM, wrote: > > Bernd, > > I also note that in the schema you provided above that the "type" > field contains a union containing a single element. Is that > intentional? If not, you have an extra set of square brackets around > "WPPageType". > I simplified my schema

Re: Avro-C: namespace lookup and inherited namespaces

2013-05-07 Thread Ben Walsh
It looks like a similar approach -- the parser functions now take the namespace of the enclosing scope (the Ruby version calls it "default_namespace" and I call it "parent_namespace"). Plus there's some extra logic to take into account the fully-qualified name. Thanks for pointing that out.

[jira] [Commented] (AVRO-1320) Java: Trevni incorrectly reads specific enums.

2013-05-07 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650984#comment-13650984 ] Doug Cutting commented on AVRO-1320: Can you please post the full schema and stack trac

Re: Reading nested specific type

2013-05-07 Thread Doug Cutting
On Tue, May 7, 2013 at 7:35 AM, Bernd Fondermann wrote: > The original schema contains a union of WPPageType and "null". I fixed a bug with specific enums, but there may still be a problem with enums in unions. I'll take another look. Doug

[jira] [Updated] (AVRO-1316) IDL code-generation generates too-long literals for very large schemas

2013-05-07 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated AVRO-1316: --- Attachment: AVRO-1316.patch Micah, thanks for validating the patch. Here's a slightly updated version

[jira] [Updated] (AVRO-1316) IDL code-generation generates too-long literals for very large schemas

2013-05-07 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated AVRO-1316: --- Affects Version/s: (was: 1.7.5) Fix Version/s: 1.7.5 Assignee: Jeremy Kahn

[jira] [Commented] (AVRO-1316) IDL code-generation generates too-long literals for very large schemas

2013-05-07 Thread Micah Huff (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651117#comment-13651117 ] Micah Huff commented on AVRO-1316: -- Looks good! Thank you Doug. > IDL cod

[jira] [Commented] (AVRO-1320) Java: Trevni incorrectly reads specific enums.

2013-05-07 Thread Bernd Fondermann (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651183#comment-13651183 ] Bernd Fondermann commented on AVRO-1320: stack trace: Exception in thread "main" j

[jira] [Commented] (AVRO-1320) Java: Trevni incorrectly reads specific enums.

2013-05-07 Thread Bernd Fondermann (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651220#comment-13651220 ] Bernd Fondermann commented on AVRO-1320: with a simple nested enum type the patch f

Re: Reading nested specific type

2013-05-07 Thread Bernd Fondermann
On Tue, May 7, 2013 at 6:05 PM, Doug Cutting wrote: > On Tue, May 7, 2013 at 7:35 AM, Bernd Fondermann > wrote: > > The original schema contains a union of WPPageType and "null". > > I fixed a bug with specific enums, but there may still be a problem > with enums in unions. I'll take another lo

[jira] [Commented] (AVRO-1316) IDL code-generation generates too-long literals for very large schemas

2013-05-07 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651254#comment-13651254 ] Scott Carey commented on AVRO-1316: --- Looks good. +1 > IDL code-generat

[jira] [Created] (AVRO-1325) Enhanced Schema Builder API

2013-05-07 Thread Scott Carey (JIRA)
Scott Carey created AVRO-1325: - Summary: Enhanced Schema Builder API Key: AVRO-1325 URL: https://issues.apache.org/jira/browse/AVRO-1325 Project: Avro Issue Type: Bug Reporter: Scott

[jira] [Commented] (AVRO-1325) Enhanced Schema Builder API

2013-05-07 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651288#comment-13651288 ] Scott Carey commented on AVRO-1325: --- Below are the limitations that concern me from AVRO-

[jira] [Updated] (AVRO-1320) Java: Trevni incorrectly reads specific enums.

2013-05-07 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated AVRO-1320: --- Attachment: AVRO-1320.patch I found the problem with the union. The wrong schema was passed down. He

[jira] [Comment Edited] (AVRO-1325) Enhanced Schema Builder API

2013-05-07 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651288#comment-13651288 ] Scott Carey edited comment on AVRO-1325 at 5/7/13 9:10 PM: --- Below

[jira] [Commented] (AVRO-1285) Avro schema compile does not support circular reference

2013-05-07 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651326#comment-13651326 ] Doug Cutting commented on AVRO-1285: Sorry, I missed the "circular" part in the origina

Re: Reading nested specific type

2013-05-07 Thread Doug Cutting
On Tue, May 7, 2013 at 12:46 PM, Bernd Fondermann wrote: > Thanks, the bug is fixed if I don't use a union. I found the problem with unions & updated the patch for AVRO-1320 to fix this too. Please let me know if that solves things for you. > However, if there are two enums in a union, could th

[jira] [Commented] (AVRO-1325) Enhanced Schema Builder API

2013-05-07 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651368#comment-13651368 ] Scott Carey commented on AVRO-1325: --- One more bug in the AVRO-1274 implementation that wi

[jira] [Updated] (AVRO-1325) Enhanced Schema Builder API

2013-05-07 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated AVRO-1325: -- Attachment: AVRO-1325-preliminary.patch Preliminary work in progress -- mostly complete but requires mor

[jira] [Commented] (AVRO-1316) IDL code-generation generates too-long literals for very large schemas

2013-05-07 Thread Micah Huff (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651392#comment-13651392 ] Micah Huff commented on AVRO-1316: -- [~cutting] -- We're having some troubles with a 1.7.4-

[jira] [Commented] (AVRO-1316) IDL code-generation generates too-long literals for very large schemas

2013-05-07 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651402#comment-13651402 ] Doug Cutting commented on AVRO-1316: Micah, is that with my most recent version of the

Re: Reading nested specific type

2013-05-07 Thread Bernd Fondermann
On Tue, May 7, 2013 at 11:39 PM, Doug Cutting wrote: > On Tue, May 7, 2013 at 12:46 PM, Bernd Fondermann > wrote: > > Thanks, the bug is fixed if I don't use a union. > > I found the problem with unions & updated the patch for AVRO-1320 to > fix this too. Please let me know if that solves thing