[jira] [Commented] (AVRO-680) Allow for non-string keys

2015-03-11 Thread Sachin Goyal (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357968#comment-14357968 ] Sachin Goyal commented on AVRO-680: --- Thanks a lot [~rdblue]. Its good to go from my side.

[jira] [Commented] (AVRO-1562) Add support for types extending Maps/Collections

2015-03-11 Thread Sachin Goyal (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357633#comment-14357633 ] Sachin Goyal commented on AVRO-1562: I have submitted a PR for this, just in case this

[jira] [Commented] (AVRO-1562) Add support for types extending Maps/Collections

2015-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357628#comment-14357628 ] ASF GitHub Bot commented on AVRO-1562: -- GitHub user sachingsachin opened a pull reques

[GitHub] avro pull request: AVRO-1562: Support classes extending Maps/Colle...

2015-03-11 Thread sachingsachin
GitHub user sachingsachin opened a pull request: https://github.com/apache/avro/pull/25 AVRO-1562: Support classes extending Maps/Collections in Avro For classes extending collections and maps, "_avro_implicit_collection_" and "_avro_implicit_map_" fields are added in the Avro repre

[jira] [Commented] (AVRO-1569) ReflectData.AllowNull fails with polymorphism

2015-03-11 Thread Sachin Goyal (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357565#comment-14357565 ] Sachin Goyal commented on AVRO-1569: I think we probably need both the fixes. The fix

[GitHub] avro pull request: AVRO-1649: Teach SchemaCompatability to be more...

2015-03-11 Thread bcotton
GitHub user bcotton opened a pull request: https://github.com/apache/avro/pull/24 AVRO-1649: Teach SchemaCompatability to be more descriptive with failing compatibility checks. Also adds enums to SchemaCompatability.SchemaCompatibilityType for the various compatability checks. You

[jira] [Commented] (AVRO-1649) SchemaCompatability should be more descriptive when schemas are incompatible

2015-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357498#comment-14357498 ] ASF GitHub Bot commented on AVRO-1649: -- GitHub user bcotton opened a pull request:

[jira] [Created] (AVRO-1649) SchemaCompatability should be more descriptive when schemas are incompatible

2015-03-11 Thread Bob Cotton (JIRA)
Bob Cotton created AVRO-1649: Summary: SchemaCompatability should be more descriptive when schemas are incompatible Key: AVRO-1649 URL: https://issues.apache.org/jira/browse/AVRO-1649 Project: Avro

[jira] [Commented] (AVRO-680) Allow for non-string keys

2015-03-11 Thread Ryan Blue (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357337#comment-14357337 ] Ryan Blue commented on AVRO-680: Thanks [~sachingoyal]! Everything looks good, I'll commit t

[jira] [Commented] (AVRO-1569) ReflectData.AllowNull fails with polymorphism

2015-03-11 Thread Sachin Goyal (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357320#comment-14357320 ] Sachin Goyal commented on AVRO-1569: {quote} When resolving the union, we just need to