Re: Drop hadoop1 support in Avro 1.9

2017-07-27 Thread Sean Busbey
+1 sounds great. We can let user@avro know about the plan once we have the change in place, so there's still time if someone has a compelling reason staying on Avro 1.7 or 1.8 can't work for hadoop1 folks. On Thu, Jul 27, 2017 at 12:52 AM, Gabor Szadovszky wrote: > Hi All, > >

[jira] [Commented] (AVRO-2058) ReflectData#isNonStringMap returns true for Utf8 keys

2017-07-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103636#comment-16103636 ] ASF GitHub Bot commented on AVRO-2058: -- GitHub user samschlegel opened a pull request:

[GitHub] avro pull request #237: [AVRO-2058] ReflectData#isNonStringMap returns true ...

2017-07-27 Thread samschlegel
GitHub user samschlegel opened a pull request: https://github.com/apache/avro/pull/237 [AVRO-2058] ReflectData#isNonStringMap returns true for Utf8 keys https://issues.apache.org/jira/browse/AVRO-2058 Since `Utf8` does not have an `Stringable` notation, and is not in

Re: Drop hadoop1 support in Avro 1.9

2017-07-27 Thread Ryan Blue
+1 On Thu, Jul 27, 2017 at 8:45 AM, Ben McCann wrote: > +1 > > Get Outlook for Android > > > From: Nandor Kollar > Sent: Thursday, July 27, 2017 1:36:15 AM > To: dev@avro.apache.org > Subject:

Re: Drop hadoop1 support in Avro 1.9

2017-07-27 Thread Niels Basjes
Yes. Good idea. +1 On Jul 27, 2017 09:52, "Gabor Szadovszky" wrote: > Hi All, > > It has already appeared in some discussions/code reviews that we might not > want to support hadoop1 anymore. As it would be a breaking change I would > suggest removing the hadoop1 support in

[jira] [Commented] (AVRO-2055) Remove Magic Value From org.apache.avro.hadoop.io.AvroSequenceFile

2017-07-27 Thread Gabor Szadovszky (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102915#comment-16102915 ] Gabor Szadovszky commented on AVRO-2055: [~belugabehr], sorry I've just realised during doing a

Drop hadoop1 support in Avro 1.9

2017-07-27 Thread Gabor Szadovszky
Hi All, It has already appeared in some discussions/code reviews that we might not want to support hadoop1 anymore. As it would be a breaking change I would suggest removing the hadoop1 support in the next major release 1.9.0. What do you think? Cheers, Gabor

[jira] [Commented] (AVRO-2056) DirectBinaryEncoder Creates Buffer For Each Call To writeDouble

2017-07-27 Thread Gabor Szadovszky (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102845#comment-16102845 ] Gabor Szadovszky commented on AVRO-2056: [~belugabehr], I've took a look on Perf and I see how it

[jira] [Commented] (AVRO-2049) Remove Superfluous Configuration From AvroSerializer

2017-07-27 Thread Gabor Szadovszky (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102841#comment-16102841 ] Gabor Szadovszky commented on AVRO-2049: +1 will commit tomorrow if no more comments [~nkollar], I

[jira] [Commented] (AVRO-2048) Avro Binary Decoding - Gracefully Handle Long Strings

2017-07-27 Thread Gabor Szadovszky (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102826#comment-16102826 ] Gabor Szadovszky commented on AVRO-2048: Thanks, [~belugabehr], I'll wait another day for