[jira] [Commented] (AVRO-2115) Support @Union in members too

[ https://issues.apache.org/jira/browse/AVRO-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289918#comment-16289918 ] Doug Cutting commented on AVRO-2115: +1 This looks like a good fix. @Union should apply to fields as

Re: Licensing problem (LGPL in codebase!!)

In addition to Zoltan we'll need to confirm anyone else who has modified the files. On Dec 13, 2017 11:46, "Sean Busbey" wrote: > Have these files made it into a release? > > On Dec 13, 2017 10:18, "Niels Basjes" wrote: > >> Zoltan, >> >> Because the

Re: Licensing problem (LGPL in codebase!!)

Have these files made it into a release? On Dec 13, 2017 10:18, "Niels Basjes" wrote: > Zoltan, > > Because the copyright notice now says you own it I guess the best way to > approach this is is when you put up a pull request with all those files > files having a new license

Re: Licensing problem (LGPL in codebase!!)

Zoltan, Because the copyright notice now says you own it I guess the best way to approach this is is when you put up a pull request with all those files files having a new license header. That way it is clear that you made the license switch. I think this should be a separate jira to document

Re: Licensing problem (LGPL in codebase!!)

Hi Niels, the license is a mistake made by me. Those files were based from my work on spf4j-avro which is currently dual licensed with LGPL and Apache . We should just replace the license headers with the appropriate Apache header. Let me know if you need me to do anything. Thank you --z >

Re: Licensing problem (LGPL in codebase!!)

+1 On Wed, Dec 13, 2017 at 4:05 PM, Nandor Kollar wrote: > I've one question regarding this: why do we execute Rat plugin *only* in > rat profile, is there any specific reason? Should include this into test > phase, so Maven test would fail, thus we can avoid similar

Re: Licensing problem (LGPL in codebase!!)

I've one question regarding this: why do we execute Rat plugin *only* in rat profile, is there any specific reason? Should include this into test phase, so Maven test would fail, thus we can avoid similar problems? On Wed, Dec 13, 2017 at 2:14 PM, Niels Basjes wrote: > Hi all,

[jira] [Updated] (AVRO-2117) Overall cleanup of code

[ https://issues.apache.org/jira/browse/AVRO-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niels Basjes updated AVRO-2117: --- Summary: Overall cleanup of code (was: Overall cleanup of java code) > Overall cleanup of code >

[jira] [Updated] (AVRO-2117) Overall cleanup of java code

[ https://issues.apache.org/jira/browse/AVRO-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niels Basjes updated AVRO-2117: --- Summary: Overall cleanup of java code (was: Overall cleanup of code) > Overall cleanup of java code >

Licensing problem (LGPL in codebase!!)

Hi all, I was going through the codebase and I found that several files are not Apache licensed. https://github.com/apache/avro/tree/master/lang/java/compiler/src/main/java/org/apache/avro/compiler/schema Some of these files do not have a copyright block (fixable), yet some have this: /* *

[jira] [Commented] (AVRO-2118) Rat tool fails over several files.

[ https://issues.apache.org/jira/browse/AVRO-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289221#comment-16289221 ] ASF subversion and git services commented on AVRO-2118: --- Commit

[jira] [Updated] (AVRO-2118) Rat tool fails over several files.

[ https://issues.apache.org/jira/browse/AVRO-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niels Basjes updated AVRO-2118: --- Summary: Rat tool fails over several files. (was: Add missing license headers) > Rat tool fails over

[jira] [Commented] (AVRO-2118) Rat tool fails over several files.

[ https://issues.apache.org/jira/browse/AVRO-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289220#comment-16289220 ] Niels Basjes commented on AVRO-2118: A {{./build.sh rat}} currently fails. > Rat tool fails over

[jira] [Created] (AVRO-2118) Add missing license headers

Niels Basjes created AVRO-2118: -- Summary: Add missing license headers Key: AVRO-2118 URL: https://issues.apache.org/jira/browse/AVRO-2118 Project: Avro Issue Type: Bug Reporter:

[jira] [Created] (AVRO-2117) Overall cleanup of code

Niels Basjes created AVRO-2117: -- Summary: Overall cleanup of code Key: AVRO-2117 URL: https://issues.apache.org/jira/browse/AVRO-2117 Project: Avro Issue Type: Improvement Reporter:

[jira] [Commented] (AVRO-2115) Support @Union in members too

[ https://issues.apache.org/jira/browse/AVRO-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289106#comment-16289106 ] Miguel commented on AVRO-2115: -- I have prepared a patch. Check it out at

[jira] [Commented] (AVRO-1047) Generated Java classes for specific records contain unchecked casts

[ https://issues.apache.org/jira/browse/AVRO-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289092#comment-16289092 ] ASF GitHub Bot commented on AVRO-1047: -- Github user mkw closed the pull request at:

[GitHub] avro pull request #250: AVRO-1047: Java: Fix remaining javac warnings.

Github user mkw closed the pull request at: https://github.com/apache/avro/pull/250 ---

[jira] [Updated] (AVRO-2116) unknown fields in json not ignored

[ https://issues.apache.org/jira/browse/AVRO-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] redlion updated AVRO-2116: -- Description: As the screenshot, I put two unknown field, one field 'unknown1' is under root level, and another

[jira] [Updated] (AVRO-2116) unknown fields in json not ignored

[ https://issues.apache.org/jira/browse/AVRO-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] redlion updated AVRO-2116: -- Description: As the screenshot, I put two unknown field, one field 'unknown1' is under root level, and another

[jira] [Created] (AVRO-2116) unknown fields in json not ignored

redlion created AVRO-2116: - Summary: unknown fields in json not ignored Key: AVRO-2116 URL: https://issues.apache.org/jira/browse/AVRO-2116 Project: Avro Issue Type: Bug Affects Versions: 1.8.1

[jira] [Commented] (AVRO-2080) Fix Javadoc Warnings in Generated Records

[ https://issues.apache.org/jira/browse/AVRO-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289000#comment-16289000 ] ASF GitHub Bot commented on AVRO-2080: -- Github user asfgit closed the pull request at:

[jira] [Commented] (AVRO-2080) Fix Javadoc Warnings in Generated Records

[ https://issues.apache.org/jira/browse/AVRO-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288999#comment-16288999 ] ASF subversion and git services commented on AVRO-2080: --- Commit

[jira] [Updated] (AVRO-2080) Fix Javadoc Warnings in Generated Records

[ https://issues.apache.org/jira/browse/AVRO-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niels Basjes updated AVRO-2080: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Fix Javadoc Warnings in Generated

[GitHub] avro pull request #254: AVRO-2080: Fix Generated Record Javadocs

Github user asfgit closed the pull request at: https://github.com/apache/avro/pull/254 ---

[jira] [Commented] (AVRO-2080) Fix Javadoc Warnings in Generated Records

[ https://issues.apache.org/jira/browse/AVRO-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288997#comment-16288997 ] ASF subversion and git services commented on AVRO-2080: --- Commit

[jira] [Updated] (AVRO-2080) Fix Javadoc Warnings in Generated Records

[ https://issues.apache.org/jira/browse/AVRO-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niels Basjes updated AVRO-2080: --- Fix Version/s: 1.8.3 1.9.0 > Fix Javadoc Warnings in Generated Records >

[jira] [Resolved] (AVRO-1047) Generated Java classes for specific records contain unchecked casts

[ https://issues.apache.org/jira/browse/AVRO-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niels Basjes resolved AVRO-1047. Resolution: Fixed Assignee: Niels Basjes > Generated Java classes for specific records contain

[jira] [Commented] (AVRO-1047) Generated Java classes for specific records contain unchecked casts

[ https://issues.apache.org/jira/browse/AVRO-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288957#comment-16288957 ] ASF subversion and git services commented on AVRO-1047: --- Commit

[jira] [Commented] (AVRO-1913) No warnings in the generated Java code

[ https://issues.apache.org/jira/browse/AVRO-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288958#comment-16288958 ] ASF subversion and git services commented on AVRO-1913: --- Commit

[jira] [Updated] (AVRO-1047) Generated Java classes for specific records contain unchecked casts

[ https://issues.apache.org/jira/browse/AVRO-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niels Basjes updated AVRO-1047: --- Fix Version/s: 1.8.3 1.9.0 > Generated Java classes for specific records contain

[jira] [Commented] (AVRO-1913) No warnings in the generated Java code

[ https://issues.apache.org/jira/browse/AVRO-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288922#comment-16288922 ] ASF subversion and git services commented on AVRO-1913: --- Commit

[jira] [Commented] (AVRO-1047) Generated Java classes for specific records contain unchecked casts

[ https://issues.apache.org/jira/browse/AVRO-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288921#comment-16288921 ] ASF subversion and git services commented on AVRO-1047: --- Commit

[jira] [Comment Edited] (AVRO-2115) Support @Union in members too

[ https://issues.apache.org/jira/browse/AVRO-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288851#comment-16288851 ] Miguel edited comment on AVRO-2115 at 12/13/17 8:38 AM: That is not allowed.

[jira] [Comment Edited] (AVRO-2115) Support @Union in members too

[ https://issues.apache.org/jira/browse/AVRO-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288851#comment-16288851 ] Miguel edited comment on AVRO-2115 at 12/13/17 8:37 AM: That is not allowed.

[jira] [Comment Edited] (AVRO-2115) Support @Union in members too

[ https://issues.apache.org/jira/browse/AVRO-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288851#comment-16288851 ] Miguel edited comment on AVRO-2115 at 12/13/17 8:36 AM: That is not allowed.

[jira] [Comment Edited] (AVRO-2115) Support @Union in members too

[ https://issues.apache.org/jira/browse/AVRO-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288851#comment-16288851 ] Miguel edited comment on AVRO-2115 at 12/13/17 8:35 AM: That is not allowed.

[jira] [Comment Edited] (AVRO-2115) Support @Union in members too

[ https://issues.apache.org/jira/browse/AVRO-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287765#comment-16287765 ] Miguel edited comment on AVRO-2115 at 12/13/17 8:31 AM: This should do the job:

[jira] [Comment Edited] (AVRO-2115) Support @Union in members too

[ https://issues.apache.org/jira/browse/AVRO-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287765#comment-16287765 ] Miguel edited comment on AVRO-2115 at 12/13/17 8:05 AM: This should do the job:

[jira] [Comment Edited] (AVRO-2115) Support @Union in members too

[ https://issues.apache.org/jira/browse/AVRO-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288851#comment-16288851 ] Miguel edited comment on AVRO-2115 at 12/13/17 8:00 AM: That is not allowed.

[jira] [Commented] (AVRO-2115) Support @Union in members too

[ https://issues.apache.org/jira/browse/AVRO-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288851#comment-16288851 ] Miguel commented on AVRO-2115: -- That is not allowed. Checking