Re: Licensing problem (LGPL in codebase!!)

2017-12-14 Thread Suraj Acharya
As part of the release we do run the rat plugin. So it is a highly unlikely this would have been run through a release. However, changing it now is a great addition since the release manager has to go through the whole license check for all of the files. Also, as Sean mentioned anyone who has made

[jira] [Commented] (AVRO-2115) Support @Union in members too

2017-12-14 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290950#comment-16290950 ] Doug Cutting commented on AVRO-2115: Yes, that should be fixed in the package documentation. Also,

[jira] [Comment Edited] (AVRO-2118) Rat tool fails over several files.

2017-12-14 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290829#comment-16290829 ] Zoltan Farkas edited comment on AVRO-2118 at 12/14/17 1:39 PM: --- created PR:

[jira] [Commented] (AVRO-2118) Rat tool fails over several files.

2017-12-14 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290829#comment-16290829 ] Zoltan Farkas commented on AVRO-2118: - will create a PR, and add the details to this JIRA. > Rat tool

[GitHub] avro pull request #266: Avro 2117 code cleanup

2017-12-14 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request: https://github.com/apache/avro/pull/266 Avro 2117 code cleanup This is a massive set of changes to reduce the number of needless warnings in the (mostly Java) code base. I have kept each type of change in a separate commit so we

Re: Licensing problem (LGPL in codebase!!)

2017-12-14 Thread Niels Basjes
Hi all, After we hear back from Thiru I would like Zoltan to fix these 4 files. lang/java/compiler/src/main/java/org/apache/avro/compiler/schema/SchemaVisitorAction.java lang/java/compiler/src/main/java/org/apache/avro/compiler/schema/SchemaVisitor.java

[jira] [Commented] (AVRO-2118) Rat tool fails over several files.

2017-12-14 Thread Niels Basjes (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290705#comment-16290705 ] Niels Basjes commented on AVRO-2118: [~zolyfarkas]: These are the 4 remaining files

[jira] [Assigned] (AVRO-2118) Rat tool fails over several files.

2017-12-14 Thread Niels Basjes (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niels Basjes reassigned AVRO-2118: -- Assignee: Zoltan Farkas (was: Niels Basjes) > Rat tool fails over several files. >

[jira] [Updated] (AVRO-2119) Run rat tool as part of the regular (java) build.

2017-12-14 Thread Niels Basjes (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niels Basjes updated AVRO-2119: --- Fix Version/s: 1.8.3 1.9.0 > Run rat tool as part of the regular (java) build. >

[jira] [Commented] (AVRO-2119) Run Apache Rat check on every java build

2017-12-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290695#comment-16290695 ] ASF GitHub Bot commented on AVRO-2119: -- GitHub user nielsbasjes opened a pull request:

[GitHub] avro pull request #265: AVRO-2119: Run Apache Rat check on every java build

2017-12-14 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request: https://github.com/apache/avro/pull/265 AVRO-2119: Run Apache Rat check on every java build This simply forces Apache Rat to run on every Java build. Must be committed to branch-1.7 branch-1.8 and master. You can merge this pull

[jira] [Updated] (AVRO-2118) Rat tool fails over several files.

2017-12-14 Thread Niels Basjes (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niels Basjes updated AVRO-2118: --- Fix Version/s: (was: 1.8.3) > Rat tool fails over several files. >

[jira] [Updated] (AVRO-2119) Run Apache Rat check on every java build

2017-12-14 Thread Niels Basjes (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niels Basjes updated AVRO-2119: --- Summary: Run Apache Rat check on every java build (was: Run rat tool as part of the regular (java)

[jira] [Updated] (AVRO-2118) Rat tool fails over several files.

2017-12-14 Thread Niels Basjes (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niels Basjes updated AVRO-2118: --- Fix Version/s: 1.8.3 1.9.0 > Rat tool fails over several files. >

[jira] [Created] (AVRO-2119) Run rat tool as part of the regular (java) build.

2017-12-14 Thread Niels Basjes (JIRA)
Niels Basjes created AVRO-2119: -- Summary: Run rat tool as part of the regular (java) build. Key: AVRO-2119 URL: https://issues.apache.org/jira/browse/AVRO-2119 Project: Avro Issue Type:

Re: Licensing problem (LGPL in codebase!!)

2017-12-14 Thread Niels Basjes
Hi all, I had a closer look at the code base. Most important: 1) I have found these files only in the master branch. 2) I checked both release 1.8.2 and 1.7.7 and in these files are NOT present in any of those releases. ( So we're ok on this part. I have found exactly 2 files with this problem:

[jira] [Comment Edited] (AVRO-2115) Support @Union in members too

2017-12-14 Thread Miguel (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290624#comment-16290624 ] Miguel edited comment on AVRO-2115 at 12/14/17 9:47 AM: Good! Added Void to the

[jira] [Commented] (AVRO-2115) Support @Union in members too

2017-12-14 Thread Miguel (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290624#comment-16290624 ] Miguel commented on AVRO-2115: -- Good! Added Void to the test. I have seen that