[jira] [Commented] (AVRO-2275) Refactor schema-resolution code from grammar-generation

2018-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705698#comment-16705698 ] ASF GitHub Bot commented on AVRO-2275: -- rstata commented on issue #395: AVRO-2275 Ref

Re: Tagging PRs in github

2018-11-30 Thread Michael A. Smith
Thanks for doing that. It was very needed. Can we automate doing this somehow. On Thu, Nov 29, 2018 at 17:52 Ismaël Mejía wrote: > Hello, > > I tagged all open PRs in github using the Label feature and the > respective languages as part of the effort to get more reviews done. > Hopefully people

Re: Radical idea for 1.9.0

2018-11-30 Thread Rob Turner
I think that recursive schemas are a powerful feature of Avro that enable the modelling of hierarchies, a pretty common data structure. l myself have used this feature in a large scale system before. The recursion is handled elegantly and naturally in the code with recursive functions so I don't th

Re: Radical idea for 1.9.0

2018-11-30 Thread Ryan Blue
I've used recursion in the past to use Avro to get a binary representation of JSON. Given the popularity of JSON and the fact that Avro includes support for converting it, I think it makes sense to continue allowing recursive schemas. On Fri, Nov 30, 2018 at 2:12 PM Michael A. Smith wrote: > I’m

Re: Radical idea for 1.9.0

2018-11-30 Thread Michael A. Smith
I’m against this proposal. Sure, recursion adds complexity, but recursive types are also extremely powerful and one of the most interesting features of a tool like this. I have been experimenting in the other direction; considering a way to compose avro schema descriptions in avro. Recursion is cru

Re: Radical idea for 1.9.0

2018-11-30 Thread Doug Cutting
First, this creates a data incompatibility, not just an API incompatibility, so it should not be permitted in 1.9.0. Apps that worked, even when updated for API changes, will not be able to read data they could before they upgraded. Second, folks might actually use this feature in reasonable ways

Radical idea for 1.9.0

2018-11-30 Thread Raymie Stata
I understand we've been willing to introduce backward-incompatible API changes (not file-format changes) into minor release versions. If so, here's an idea for consideration: Let's eliminate recursive records from Avro 1.9.x. Recursion introduces a _lot_ of complexity into many parts of the Avro

[jira] [Commented] (AVRO-1528) avro_schema_enum_get returns invalid pointer for unknown indices

2018-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704479#comment-16704479 ] ASF GitHub Bot commented on AVRO-1528: -- walshb commented on issue #398: AVRO-1528. C:

[jira] [Commented] (AVRO-2247) Improve Java reading performance with a new reader

2018-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704451#comment-16704451 ] ASF GitHub Bot commented on AVRO-2247: -- rstata commented on issue #391: AVRO-2247 - i