[
https://issues.apache.org/jira/browse/AVRO-3515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534302#comment-17534302
]
Anders Sundelin commented on AVRO-3515:
---
I second that. As the spec says that
[
https://issues.apache.org/jira/browse/AVRO-3048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17285812#comment-17285812
]
Anders Sundelin commented on AVRO-3048:
---
It would be worthwhile specifying
[
https://issues.apache.org/jira/browse/AVRO-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225902#comment-17225902
]
Anders Sundelin edited comment on AVRO-1751 at 11/4/20, 7:0
[
https://issues.apache.org/jira/browse/AVRO-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225902#comment-17225902
]
Anders Sundelin commented on AVRO-1751:
---
Hi [~gabriel-tincu]
That was
Hi Frederic,
Please be aware that having a default value, and use it in case of
non-parsable enum strings, would still solve your solution.
E.g:
First schema has enum { UNKNOWN, MALE, FEMALE } with default: UNKNOWN
Second schema defines additional mode, e.g. { UNKNOWN, MALE, FEMALE,
NON_BI
[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16161044#comment-16161044
]
Anders Sundelin commented on AVRO-2072:
---
+1 for patch 3, I have no further comm
[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160465#comment-16160465
]
Anders Sundelin commented on AVRO-2072:
---
Please substitute [long] with [int] i
[
https://issues.apache.org/jira/browse/AVRO-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160462#comment-16160462
]
Anders Sundelin commented on AVRO-2075:
---
Ping [~teabot], don't know
[
https://issues.apache.org/jira/browse/AVRO-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160460#comment-16160460
]
Anders Sundelin commented on AVRO-2075:
---
Relevant PR:
https://github.com/apache/
[
https://issues.apache.org/jira/browse/AVRO-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anders Sundelin updated AVRO-2075:
--
Attachment: 0001-AVRO-2075-Add-option-to-report-possible-data-loss-in.patch
> Al
Anders Sundelin created AVRO-2075:
-
Summary: Allow SchemaCompatibility to report possibly lossy
conversions
Key: AVRO-2075
URL: https://issues.apache.org/jira/browse/AVRO-2075
Project: Avro
[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160428#comment-16160428
]
Anders Sundelin commented on AVRO-2072:
---
I have reviewed your patch, [~nkollar],
[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16149057#comment-16149057
]
Anders Sundelin commented on AVRO-2072:
---
Please feel free to update the t
[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anders Sundelin updated AVRO-2072:
--
Attachment: 0001-AVRO-1931-Additional-test-cases.patch
Attached the additional test cases
[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148959#comment-16148959
]
Anders Sundelin commented on AVRO-2072:
---
Hi Nandor and others,
My bad, I base
[
https://issues.apache.org/jira/browse/AVRO-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148847#comment-16148847
]
Anders Sundelin commented on AVRO-1933:
---
Updated according to your comments, pl
admit, I am not that well versed in the Avro
release/contribution process)
On a personal note (though my application does not, to my knowledge, rely on
floats), I actually would prefer changing the spec, not allowing conversion to
float. But YMMV,
Thanks for your time,
/Anders Sundelin
[
https://issues.apache.org/jira/browse/AVRO-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anders Sundelin reassigned AVRO-1931:
-
Assignee: (was: Anders Sundelin)
> SchemaCompatibility fails to recognize rea
[
https://issues.apache.org/jira/browse/AVRO-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anders Sundelin reassigned AVRO-1933:
-
Assignee: (was: Anders Sundelin)
> SchemaCompatibility class could be more u
[
https://issues.apache.org/jira/browse/AVRO-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891887#comment-15891887
]
Anders Sundelin edited comment on AVRO-1933 at 3/2/17 10:1
[
https://issues.apache.org/jira/browse/AVRO-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891887#comment-15891887
]
Anders Sundelin commented on AVRO-1933:
---
Here is a PR for this JIRA:
h
[
https://issues.apache.org/jira/browse/AVRO-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891823#comment-15891823
]
Anders Sundelin commented on AVRO-1931:
---
Still trying to figure out how to work
[
https://issues.apache.org/jira/browse/AVRO-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anders Sundelin updated AVRO-1933:
--
Assignee: Anders Sundelin
Affects Version/s: 1.7.7
Status: Patch
[
https://issues.apache.org/jira/browse/AVRO-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anders Sundelin updated AVRO-1931:
--
Assignee: Anders Sundelin
Affects Version/s: 1.7.7
Status: Patch
[
https://issues.apache.org/jira/browse/AVRO-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anders Sundelin updated AVRO-1931:
--
Labels: patch (was: )
> SchemaCompatibility fails to recognize reader compatible with
[
https://issues.apache.org/jira/browse/AVRO-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885420#comment-15885420
]
Anders Sundelin commented on AVRO-1931:
---
Sure could, I just wanted someone els
[
https://issues.apache.org/jira/browse/AVRO-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876063#comment-15876063
]
Anders Sundelin commented on AVRO-1933:
---
I agree that the addition of
Hi,
For Java, there is a SchemaCompatibility class that tells if two schemas
are compatible in the reader/writer sense.
A while back, I noted some issues, and evolved this class a bit, making
it a bit more user friendly.
There are still some issues, particularly with float unions, but if yo
There are many arguments for/against Optionals on the web, but the
consensus seem to be that Optionals are best used as method return
types, not as method parameters.
Therefore, I think the setters should still use the plain objects, as
there are anyway no practical way to enforce non-nullity
Hi Ryan,
I am new in this community, so please take my comments with that in mind :-)
The idea of splitting implementations seems very logical to me, but I
think that, as Avro is a serialization framework, there would have to be
integration tests that take into account that the byte-level
imp
[
https://issues.apache.org/jira/browse/AVRO-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568638#comment-15568638
]
Anders Sundelin edited comment on AVRO-1933 at 10/12/16 2:5
[
https://issues.apache.org/jira/browse/AVRO-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anders Sundelin updated AVRO-1933:
--
Attachment: AVRO-1933-compatible-with-AVRO-1931.patch
Patch set compatible with AVRO-1931 patch
[
https://issues.apache.org/jira/browse/AVRO-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anders Sundelin updated AVRO-1933:
--
Attachment: AVRO-1933.patch
Patch set adding more error details to SchemaCompatibility.
Also
Anders Sundelin created AVRO-1933:
-
Summary: SchemaCompatibility class could be more user-friendly
about incompatibilities
Key: AVRO-1933
URL: https://issues.apache.org/jira/browse/AVRO-1933
Project
[
https://issues.apache.org/jira/browse/AVRO-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565311#comment-15565311
]
Anders Sundelin commented on AVRO-1931:
---
After investigating this a little fur
[
https://issues.apache.org/jira/browse/AVRO-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anders Sundelin updated AVRO-1931:
--
Attachment: (was: AVRO-1931.patch)
> SchemaCompatibility fails to recognize rea
[
https://issues.apache.org/jira/browse/AVRO-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anders Sundelin updated AVRO-1931:
--
Attachment: AVRO-1931-2.patch
Updated with more test cases, showing inconsistencies with float
[
https://issues.apache.org/jira/browse/AVRO-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anders Sundelin updated AVRO-1931:
--
Attachment: AVRO-1931.patch
> SchemaCompatibility fails to recognize reader compatible with
[
https://issues.apache.org/jira/browse/AVRO-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anders Sundelin updated AVRO-1931:
--
Attachment: (was: AVRO-1931.patch)
> SchemaCompatibility fails to recognize rea
[
https://issues.apache.org/jira/browse/AVRO-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anders Sundelin updated AVRO-1931:
--
Attachment: AVRO-1931.patch
> SchemaCompatibility fails to recognize reader compatible with
Anders Sundelin created AVRO-1931:
-
Summary: SchemaCompatibility fails to recognize reader compatible
with all branches of a union
Key: AVRO-1931
URL: https://issues.apache.org/jira/browse/AVRO-1931
[
https://issues.apache.org/jira/browse/AVRO-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anders Sundelin updated AVRO-1929:
--
Status: Patch Available (was: Open)
This time, added the patch as a attached file
HTH
/Anders
[
https://issues.apache.org/jira/browse/AVRO-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anders Sundelin updated AVRO-1929:
--
Attachment: AVRO-1929.patch
Patch for AVRO-1929 issue
> SchemaCompatibility fails to recogn
[
https://issues.apache.org/jira/browse/AVRO-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anders Sundelin updated AVRO-1929:
--
Status: Open (was: Patch Available)
> SchemaCompatibility fails to recognize string<-
[
https://issues.apache.org/jira/browse/AVRO-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anders Sundelin updated AVRO-1929:
--
Status: Patch Available (was: Open)
diff --git
a/lang/java/avro/src/main/java/org/apache/avro
Anders Sundelin created AVRO-1929:
-
Summary: SchemaCompatibility fails to recognize string<->bytes
promotion
Key: AVRO-1929
URL: https://issues.apache.org/jira/browse/AVRO-1929
Project
46 matches
Mail list logo
