Canceling the vote.
Thanks Karin for giving 1.9.0 RC a try. I'll release RC4 soon with your
patch.
Cheers, Fokko
Op vr 3 mei 2019 om 12:33 schreef Nandor Kollar
:
> Okay, I created a Jira: https://issues.apache.org/jira/browse/AVRO-2386
>
> Thanks Katrin, nice catch! You can open a PR for
> htt
Okay, I created a Jira: https://issues.apache.org/jira/browse/AVRO-2386
Thanks Katrin, nice catch! You can open a PR for
https://github.com/apache/avro.
Because this is a regression, I vote -1 (non-binding) on RC3
On Fri, May 3, 2019 at 12:20 PM Katrin Skoglund
wrote:
> I realized I don't have
I realized I don't have a Jira account, should I sign up for one?
On 2019-05-03, 12:09, "Nandor Kollar" wrote:
Ah, okay, I see. Well, in this case it is a release blocker then, since it
is indeed a regression. If you've an account to Apache Jira, please file a
Jira here: https://iss
Ah, okay, I see. Well, in this case it is a release blocker then, since it
is indeed a regression. If you've an account to Apache Jira, please file a
Jira here: https://issues.apache.org/jira/projects/AVRO/issues
On Fri, May 3, 2019 at 11:38 AM Katrin Skoglund
wrote:
> Hi Nandor!
>
> Ah, I wasn'
Hi Nandor!
Ah, I wasn't aware that the method is new. What I actually meant was that code
generation that previously worked now generates code that no longer compiles,
which I would say is a regression. The implementation of customEncode() in the
class representing the outer record calls the co
Hi Katrin,
It appears to me, that these methods didn't exist in previous Avro
versions, they were added in https://github.com/apache/avro/pull/350 and
were renamed and reduced their visibility in
https://github.com/apache/avro/pull/350/commits/d320b6b536c49b485be45286dbdb73226eef4b35.
Actually it
Hi all,
I just managed to test the new RC, specifically the Java code generation, with
one of the libraries we use. I then noticed that their generated java code no
longer compiles because of a change in access level of two methods.
The generated methods customEncode and customDecode are protec
I am referring to the 'SNAPSHOT' suffix in the names (and content) of
the dist link.
https://dist.apache.org/repos/dist/dev/avro/avro-1.9.0-rc3/
It seems the github link is ok, but I assume that the 'defacto
version' for validation is the dist.apache.org one.
The binary staged artifacts look ok (t
Thank you Ismaël for looking into it and for the additional interesting
info.
Are you referring to the SNAPSHOT in the tests? I can remove these:
root@83c927afb89b:/avro# grep -R "SNAPSHOT" .
./lang/js/node_modules/uglify-js/tools/domprops.json:
"ORDERED_NODE_SNAPSHOT_TYPE",
./lang/js/node_modules
I did a quick review on the JIRA issues included and extracted some
extra interesting info worth of addint to the release notes. Up to you
to choose which matter or not to be added.
* Remove Jackson classes from public API
* Avro is built by default with Java 8
* Avro is compiled and tested too wi
Sorry, playing the killjoy again.
It seems the files (and more critical the poms) still have the -SNAPSHOT suffix.
Also the comment of Dan Kulp about the extra directory structure in
the main file build/avro-1.9.0 directory would be a nice extra thing
to fix.
On Tue, Apr 30, 2019 at 12:54 PM Dri
Hi everyone,
Since the last release of Apache Avro 1.8.2 on May 31, 2017. Two years
later,
I'm thrilled to propose the following RC to be released as official Apache
Avro 1.9.0 release.
The commit id is 24ff48c32d8d13433a1e31e485ef2af187d1eb62
* This corresponds to the tag: release-1.9.0-rc3
* ht
12 matches
Mail list logo