[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974241#comment-13974241
]
Hudson commented on AVRO-1402:
--
FAILURE: Integrated in AvroJava #451 (See
[https://builds.apa
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974174#comment-13974174
]
ASF subversion and git services commented on AVRO-1402:
---
Commit 15884
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973367#comment-13973367
]
Ryan Blue commented on AVRO-1402:
-
Created AVRO-1497 to track the logical type support in s
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973233#comment-13973233
]
Doug Cutting commented on AVRO-1402:
Yes, it sounds like a separate issue for implement
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973173#comment-13973173
]
Ryan Blue commented on AVRO-1402:
-
[~cutting], thanks for taking a look. I'll update the pa
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973158#comment-13973158
]
Jarek Jarcec Cecho commented on AVRO-1402:
--
Yes [~cutting], I do feel that it woul
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13972981#comment-13972981
]
Doug Cutting commented on AVRO-1402:
Ryanb: I'd prefer that Decimal is not a nested sub
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971638#comment-13971638
]
Ryan Blue commented on AVRO-1402:
-
I don't think we need to work with decimal objects yet,
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971615#comment-13971615
]
Jarek Jarcec Cecho commented on AVRO-1402:
--
Even though that code changes are supp
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970408#comment-13970408
]
Doug Cutting commented on AVRO-1402:
Does this need to be in Schema.java? That class is
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970302#comment-13970302
]
Ryan Blue commented on AVRO-1402:
-
I've pushed a branch to github, which may be more readab
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970093#comment-13970093
]
Doug Cutting commented on AVRO-1402:
The changes to the spec look fine, but I'd prefer
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969637#comment-13969637
]
Ryan Blue commented on AVRO-1402:
-
bq. [D]o we put upper bounds for the precision/scale?
T
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969109#comment-13969109
]
Xuefu Zhang commented on AVRO-1402:
---
Fair enough. I just liked to put all the options on
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969061#comment-13969061
]
Ryan Blue commented on AVRO-1402:
-
[~xuefuz], you're right that this is between those two a
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969022#comment-13969022
]
Xuefu Zhang commented on AVRO-1402:
---
Since the logical type approach proposed here isn't
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968981#comment-13968981
]
Ryan Blue commented on AVRO-1402:
-
The rules that can be enforced, like consistent metadata
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968962#comment-13968962
]
Xuefu Zhang commented on AVRO-1402:
---
Thanks for the clarification, [~rdblue]. That makes
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968798#comment-13968798
]
Ryan Blue commented on AVRO-1402:
-
[~xuefuz], what I'm trying to say is that it's an error
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968708#comment-13968708
]
Xuefu Zhang commented on AVRO-1402:
---
bq, Because the maximum precision varies with the le
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968559#comment-13968559
]
Ryan Blue commented on AVRO-1402:
-
bq. I think we should allow writing unspecified logical
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967214#comment-13967214
]
Xuefu Zhang commented on AVRO-1402:
---
{quote}
precision, a JSON integer representing the (
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966795#comment-13966795
]
Doug Cutting commented on AVRO-1402:
> fixed may also be annotated with a decimal logic
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966159#comment-13966159
]
Hudson commented on AVRO-1402:
--
SUCCESS: Integrated in AvroJava #450 (See
[https://builds.apa
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966052#comment-13966052
]
Ryan Blue commented on AVRO-1402:
-
bq. A logical type is always encoded in exactly the same
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965887#comment-13965887
]
Skye Wanderman-Milne commented on AVRO-1402:
Ah, makes sense. Thanks for the cl
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965862#comment-13965862
]
Ryan Blue commented on AVRO-1402:
-
bq. "Language implementations may choose to represent lo
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965808#comment-13965808
]
Skye Wanderman-Milne commented on AVRO-1402:
This looks great Tom! If I underst
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965206#comment-13965206
]
ASF subversion and git services commented on AVRO-1402:
---
Commit 15862
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964840#comment-13964840
]
Jarek Jarcec Cecho commented on AVRO-1402:
--
I really like the idea of the logical
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964588#comment-13964588
]
Doug Cutting commented on AVRO-1402:
> At this point I think we should revert this patc
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964337#comment-13964337
]
Tom White commented on AVRO-1402:
-
I think the unique name limitation is a problem. At this
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963738#comment-13963738
]
Skye Wanderman-Milne commented on AVRO-1402:
I strongly prefer the logical type
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963257#comment-13963257
]
Ryan Blue commented on AVRO-1402:
-
No problem. Going from int to long or float to double is
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963209#comment-13963209
]
Nong Li commented on AVRO-1402:
---
I see your use case as the same as going from int -> long or
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963200#comment-13963200
]
Ryan Blue commented on AVRO-1402:
-
I don't think evolution would cover the use case because
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963180#comment-13963180
]
Nong Li commented on AVRO-1402:
---
Ryan, your example seems like a schema evolution use case. E
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963146#comment-13963146
]
Ryan Blue commented on AVRO-1402:
-
bq. There have been objections to the approach implement
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963029#comment-13963029
]
Tom White commented on AVRO-1402:
-
There have been objections to the approach implemented h
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962954#comment-13962954
]
Tom White commented on AVRO-1402:
-
There has been some further (offline) discussion about w
[
https://issues.apache.org/jira/browse/AVRO-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959889#comment-13959889
]
Hudson commented on AVRO-1402:
--
SUCCESS: Integrated in AvroJava #448 (See
[https://builds.apa
41 matches
Mail list logo
