[jira] [Commented] (AVRO-1895) DeepCopy does not work with logical types

2016-09-01 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15455788#comment-15455788 ] Doug Cutting commented on AVRO-1895: Oops. Thanks for fixing that, Sean. CHANGES.txt

[jira] [Commented] (AVRO-1895) DeepCopy does not work with logical types

2016-09-01 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15455460#comment-15455460 ] Sean Busbey commented on AVRO-1895: --- I reverted and repushed with the correct JIRA key on

[jira] [Commented] (AVRO-1895) DeepCopy does not work with logical types

2016-09-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15455443#comment-15455443 ] ASF subversion and git services commented on AVRO-1895: --- Commit 9cfd3

[jira] [Commented] (AVRO-1895) DeepCopy does not work with logical types

2016-09-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15455442#comment-15455442 ] ASF subversion and git services commented on AVRO-1895: --- Commit 973aa

[jira] [Commented] (AVRO-1895) DeepCopy does not work with logical types

2016-09-01 Thread Tim Perkins (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15455221#comment-15455221 ] Tim Perkins commented on AVRO-1895: --- [~cutting], it looks like this was committed with is

[jira] [Commented] (AVRO-1895) DeepCopy does not work with logical types

2016-08-31 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453757#comment-15453757 ] Doug Cutting commented on AVRO-1895: Good catch. I just committed that change too. >

[jira] [Commented] (AVRO-1895) DeepCopy does not work with logical types

2016-08-31 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453696#comment-15453696 ] Sean Busbey commented on AVRO-1895: --- {code}+Conversion conversion = getConversionByCl

[jira] [Commented] (AVRO-1895) DeepCopy does not work with logical types

2016-08-31 Thread Ryan Blue (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453569#comment-15453569 ] Ryan Blue commented on AVRO-1895: - +1. Looks good to me. Thanks, [~cutting]! > DeepCopy do

[jira] [Commented] (AVRO-1895) DeepCopy does not work with logical types

2016-08-31 Thread Ryan Blue (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453495#comment-15453495 ] Ryan Blue commented on AVRO-1895: - I think this should use the {{getConversionByClass}} met

[jira] [Commented] (AVRO-1895) DeepCopy does not work with logical types

2016-08-31 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453480#comment-15453480 ] Sean Busbey commented on AVRO-1895: --- My concern is that reading through GenericData it lo

[jira] [Commented] (AVRO-1895) DeepCopy does not work with logical types

2016-08-31 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453459#comment-15453459 ] Doug Cutting commented on AVRO-1895: I believe that it is an error to have the conversi

[jira] [Commented] (AVRO-1895) DeepCopy does not work with logical types

2016-08-31 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453256#comment-15453256 ] Sean Busbey commented on AVRO-1895: --- Just occurred to me: Do we need to check that T is t

[jira] [Commented] (AVRO-1895) DeepCopy does not work with logical types

2016-08-31 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452355#comment-15452355 ] Sean Busbey commented on AVRO-1895: --- patch looks good [~cutting]. a few points of feedbac

[jira] [Commented] (AVRO-1895) DeepCopy does not work with logical types

2016-08-31 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452334#comment-15452334 ] Sean Busbey commented on AVRO-1895: --- {quote} bq. The workaround in AVRO-1891 may not help

[jira] [Commented] (AVRO-1895) DeepCopy does not work with logical types

2016-08-08 Thread Ryan Blue (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412011#comment-15412011 ] Ryan Blue commented on AVRO-1895: - bq. The workaround in AVRO-1891 may not help here We sh

[jira] [Commented] (AVRO-1895) DeepCopy does not work with logical types

2016-08-07 Thread Yibing Shi (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410955#comment-15410955 ] Yibing Shi commented on AVRO-1895: -- The workaround in AVRO-1891 may not help here. DeepCop

[jira] [Commented] (AVRO-1895) DeepCopy does not work with logical types

2016-08-04 Thread Ryan Blue (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408385#comment-15408385 ] Ryan Blue commented on AVRO-1895: - This looks like a duplicate of AVRO-1891. Can you confir