[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162605#comment-16162605
]
Nandor Kollar commented on AVRO-2072:
-
Thanks [~gszadovszky] and [~epkanol] for reviewi
[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162578#comment-16162578
]
ASF subversion and git services commented on AVRO-2072:
---
Commit 50eeb
[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16161149#comment-16161149
]
Gabor Szadovszky commented on AVRO-2072:
+1
Will push it soon
> ResolvingGrammarGe
[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16161044#comment-16161044
]
Anders Sundelin commented on AVRO-2072:
---
+1 for patch 3, I have no further comments,
[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160994#comment-16160994
]
Nandor Kollar commented on AVRO-2072:
-
[~epkanol] thanks for the review, in AVRO-2072_3
[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160465#comment-16160465
]
Anders Sundelin commented on AVRO-2072:
---
Please substitute [long] with [int] in my pr
[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160428#comment-16160428
]
Anders Sundelin commented on AVRO-2072:
---
I have reviewed your patch, [~nkollar], and
[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156991#comment-16156991
]
Nandor Kollar commented on AVRO-2072:
-
Thanks [~epkanol], I uploaded AVRO-2072_2.patch
[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16149057#comment-16149057
]
Anders Sundelin commented on AVRO-2072:
---
Please feel free to update the tests accordi
[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148959#comment-16148959
]
Anders Sundelin commented on AVRO-2072:
---
Hi Nandor and others,
My bad, I based my pu
[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147348#comment-16147348
]
Nandor Kollar commented on AVRO-2072:
-
Ah okay, I think the pull request for AVRO-1931
[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147312#comment-16147312
]
Zoltan Farkas commented on AVRO-2072:
-
[~nkollar] Missed that part of the spec, the pat
[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147294#comment-16147294
]
Nandor Kollar commented on AVRO-2072:
-
[~zolyfarkas] I think this is fine, the test sho
> conversion to float. But YMMV,
>
> Thanks for your time,
> /Anders Sundelin
>
>
> ---- Original Message ----
> Subject: [jira] [Commented] (AVRO-2072) ResolvingGrammarGenerator doesn't
> implement schema resolution correctly for unions
> From: "Nandor
[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147229#comment-16147229
]
Zoltan Farkas commented on AVRO-2072:
-
I executed this against my branch... which is ah
Original Message
Subject: [jira] [Commented] (AVRO-2072) ResolvingGrammarGenerator doesn't
implement schema resolution correctly for unions
From: "Nandor Kollar (JIRA)"
Date: 30 aug. 2017 13:55
To: dev@avro.apache.org
[
https://issues.apache.org/jira/browse
[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147147#comment-16147147
]
Nandor Kollar commented on AVRO-2072:
-
[~zolyfarkas] I don't see any test failure, gues
[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147116#comment-16147116
]
Nandor Kollar commented on AVRO-2072:
-
Thanks Zoltan, I'll have a look at the failing t
[
https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147089#comment-16147089
]
Zoltan Farkas commented on AVRO-2072:
-
Applying the patch results in some test failures
19 matches
Mail list logo
