Re: Feature freeze Apache Avro 1.9

Hi, On 2019/03/29 21:26:02, "Driesprong, Fokko" wrote: > Thanks all for the feedback. > > Regarding the discussion Joda time, I've made a PR to completely remove the > Joda dependency: https://github.com/apache/avro/pull/495 > > What do you guys think, could we push this for 1.9? This would o

Re: Feature freeze Apache Avro 1.9

Just to clarify, the UUID logical type was included in 1.8.2 (and perhaps a release prior to that?), it was just undocumented. So I think one option could be providing a conversion both to/from string and to/from 16-length fixed, similar to the way that the decimal type provides conversion to/fr

Re: Feature freeze Apache Avro 1.9

Hi Ivan, Thanks for the input. Personally, I'm not using the UUID at all. Any comments on it Ryan? Since it isn't introduced in any release, we could remove it if there is a consensus if it doesn't add any value to the Avro format. Apart from that, I did some testing last week on some internal pr

Re: Feature freeze Apache Avro 1.9

Somehow only now after I sent this last message did I realize the conversion can already be controlled by adding the LogicalType to ReflectData as in TestReflectLogicalTypes.java :) So never mind on that second part. However it's worth making a consideration about whether we are interested in revi

Re: Feature freeze Apache Avro 1.9

Another outstanding bit for the release in my mind is the state of the UUID logicalType. As Ryan commented here: https://issues.apache.org/jira/browse/AVRO-2021?focusedCommentId=16242524&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16242524 there is currently an imp

Re: Feature freeze Apache Avro 1.9

Hi Fokko, just now seeing your original email about features for 1.9. I have a small enhancement to ReflectData's protocol building ready for review here: https://github.com/apache/avro/pull/490 I also opened a Jira earlier today about enhancements to t

Re: Feature freeze Apache Avro 1.9

Thanks all for the feedback. Regarding the discussion Joda time, I've made a PR to completely remove the Joda dependency: https://github.com/apache/avro/pull/495 What do you guys think, could we push this for 1.9? This would obviously break backward compatibility, but then again, people should no

Re: Feature freeze Apache Avro 1.9

I totally support making JSR310 as the default instead of Joda time. Should we consider removing the JSR310 from the class names, for example rename Jsr310TimeConversions to TimeConversions and the existing TimeConversions to JodaTimeConversions, and deprecate the latter? On Thu, Mar 28, 2019 at 6

Re: Feature freeze Apache Avro 1.9

I made few commits today that change the generated code from the Schema compiler a bit…. The changes make Avro 1.9 a bit more incompatible with 1.8, but since they are going to have to migrate anyway, I thought it would be important to make the changes now rather then forcing everyone to do so

Re: Feature freeze Apache Avro 1.9

Agree -Suraj Acharya On Tue, Mar 26, 2019 at 8:27 AM Ismaël Mejía wrote: > Thanks for taking care of this Fokko, I am really excited of getting a > new version out! > > I went through the list of open issues that are tagged for 2.9.0 > > > https://issues.apache.org/jira/issues/?jql=project%20%3

Re: Feature freeze Apache Avro 1.9

Thanks for taking care of this Fokko, I am really excited of getting a new version out! I went through the list of open issues that are tagged for 2.9.0 https://issues.apache.org/jira/issues/?jql=project%20%3D%20AVRO%20AND%20status%20in%20(Open%2C%20%22In%20Progress%22%2C%20Reopened)%20AND%20fixV

Feature freeze Apache Avro 1.9

Hi all, I'd like to cut the branch for Apache Avro 1.9 release this Friday, and start moving to a release candidate so we can test. If there are any features that you would like to get in, please let me know. Cheers, Fokko