Re: Pre-commit Check Avro

2016-09-13 Thread Sean Busbey
We have something like this now with our build.sh files, I think? Busbey-MBA:avro busbey$ find . -name build.sh ./build.sh ./lang/c/build.sh ./lang/c++/build.sh ./lang/csharp/build.sh ./lang/js/build.sh ./lang/php/build.sh ./lang/ruby/build.sh how about we just formalize this for the places

Re: Pre-commit Check Avro

2016-09-13 Thread suraj acharya
Hi, When I reached out to the Apache Yetus dev mailing list for some information regarding the addition of precommit check. I got the reply from them which said that AVRO might want to change the approach of which they run the tests. I wanted to know if everyone was okay with what was being

Re: Pre-commit Check Avro

2016-08-19 Thread Sean Busbey
If we have files that fail to include the required ASF licensing headers, you're correct that's important to fix. I think either working on it before or after would be fine. Ideally, Yetus Precommit should properly let us know when a patch is fixing those kinds of problems, so it would be a good

Re: Pre-commit Check Avro

2016-08-18 Thread suraj acharya
Okay. I will look at the docker command and the image. One other question I have is that the asflicense is an important aspect of yetus. However, many java files have that missing. And whenever a patch touches that file it returns a -1. Do you think I should first fix all the licenses and then

Re: Pre-commit Check Avro

2016-08-18 Thread Sean Busbey
is the 3-5 minutes doing the tests across all of the language libraries or just the java ones? docker will definitely be needed, due to the number of different system dependencies needed to build the different languages. I was hoping we could reuse the Docker image that is currently used for the