[jira] [Commented] (AVRO-3051) Modernize C++ implementation

2021-03-30 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312038#comment-17312038 ] Thiruvalluvan M. G. commented on AVRO-3051: --- The [next

[jira] [Comment Edited] (AVRO-3051) Modernize C++ implementation

2021-03-24 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308303#comment-17308303 ] Thiruvalluvan M. G. edited comment on AVRO-3051 at 3/25/21, 2:36 AM: -

[jira] [Commented] (AVRO-3051) Modernize C++ implementation

2021-03-24 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308303#comment-17308303 ] Thiruvalluvan M. G. commented on AVRO-3051: --- Made the next installment:

[jira] [Updated] (AVRO-3070) [Build] C++ lint is failing Github Actions

2021-03-21 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvalluvan M. G. updated AVRO-3070: -- Component/s: c++ > [Build] C++ lint is failing Github Actions >

[jira] [Commented] (AVRO-3070) [Build] C++ lint is failing Github Actions

2021-03-21 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305701#comment-17305701 ] Thiruvalluvan M. G. commented on AVRO-3070: --- I made a PR with the actual fix. Instead of holding

[jira] [Updated] (AVRO-3089) Fix Warnings during C++ build

2021-03-21 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvalluvan M. G. updated AVRO-3089: -- Description: The C++ build generates 10 warnings in our automated builds. See for

[jira] [Commented] (AVRO-3089) Fix Warnings during C++ build

2021-03-21 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305718#comment-17305718 ] Thiruvalluvan M. G. commented on AVRO-3089: --- The 10 warnings no longer appear:

[jira] [Resolved] (AVRO-3070) [Build] C++ lint is failing Github Actions

2021-03-21 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvalluvan M. G. resolved AVRO-3070. --- Resolution: Fixed Merged the PR > [Build] C++ lint is failing Github Actions >

[jira] [Assigned] (AVRO-3070) [Build] C++ lint is failing Github Actions

2021-03-21 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvalluvan M. G. reassigned AVRO-3070: - Assignee: Thiruvalluvan M. G. > [Build] C++ lint is failing Github Actions >

[jira] [Created] (AVRO-3089) C++ Warnings

2021-03-21 Thread Thiruvalluvan M. G. (Jira)
Thiruvalluvan M. G. created AVRO-3089: - Summary: C++ Warnings Key: AVRO-3089 URL: https://issues.apache.org/jira/browse/AVRO-3089 Project: Apache Avro Issue Type: Improvement

[jira] [Updated] (AVRO-3089) Fix Warnings during C++ build

2021-03-21 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvalluvan M. G. updated AVRO-3089: -- Summary: Fix Warnings during C++ build (was: C++ Warnings) > Fix Warnings during C++

[jira] [Updated] (AVRO-3087) Can't build Avro C++ without Snappy

2021-03-22 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvalluvan M. G. updated AVRO-3087: -- Resolution: Fixed Status: Resolved (was: Patch Available) Merged the PR. Thank

[jira] [Resolved] (AVRO-3089) Fix Warnings during C++ build

2021-03-22 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvalluvan M. G. resolved AVRO-3089. --- Resolution: Fixed Merged the PR after addressing [~emkornfield]'s review comments.

[jira] [Commented] (AVRO-3070) [Build] C++ lint is failing Github Actions

2021-03-22 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306275#comment-17306275 ] Thiruvalluvan M. G. commented on AVRO-3070: --- [~rskraba], I'm sorry I did not intend to supersede

[jira] [Commented] (AVRO-3070) [Build] C++ lint is failing Github Actions

2021-03-22 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306272#comment-17306272 ] Thiruvalluvan M. G. commented on AVRO-3070: --- [~mitjap], thanks for reviewing it. I agree that

[jira] [Commented] (AVRO-3051) Modernize C++ implementation

2021-02-25 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290953#comment-17290953 ] Thiruvalluvan M. G. commented on AVRO-3051: --- The first installment of changes is at

[jira] [Resolved] (AVRO-2933) avro c++ CMakeList enforces a specific version of C++ instead of letting user CXXFLAGS

2021-03-07 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvalluvan M. G. resolved AVRO-2933. --- Fix Version/s: 1.11.0 Resolution: Fixed Merged the pull request. Thank you

[jira] [Commented] (AVRO-3051) Modernize C++ implementation

2021-03-07 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296889#comment-17296889 ] Thiruvalluvan M. G. commented on AVRO-3051: --- Merged the PR. Thanks a lot [~emkornfield] for your

[jira] [Assigned] (AVRO-2933) avro c++ CMakeList enforces a specific version of C++ instead of letting user CXXFLAGS

2021-03-07 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvalluvan M. G. reassigned AVRO-2933: - Assignee: Thomas Barbier > avro c++ CMakeList enforces a specific version of C++

[jira] [Resolved] (AVRO-3031) avrocppgen does not generate correct C++ code when the schema contains C++ reserved words.

2021-02-23 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvalluvan M. G. resolved AVRO-3031. --- Resolution: Fixed Merged the Pull Request. Thanks a ton [~areese999] > avrocppgen

[jira] [Assigned] (AVRO-3031) avrocppgen does not generate correct C++ code when the schema contains C++ reserved words.

2021-02-23 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvalluvan M. G. reassigned AVRO-3031: - Assignee: Allen Reese > avrocppgen does not generate correct C++ code when the

[jira] [Updated] (AVRO-3051) Modernize C++ implementation

2021-02-23 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvalluvan M. G. updated AVRO-3051: -- Component/s: c++ > Modernize C++ implementation > > >

[jira] [Created] (AVRO-3051) Modernize C++ implementation

2021-02-23 Thread Thiruvalluvan M. G. (Jira)
Thiruvalluvan M. G. created AVRO-3051: - Summary: Modernize C++ implementation Key: AVRO-3051 URL: https://issues.apache.org/jira/browse/AVRO-3051 Project: Apache Avro Issue Type:

[jira] [Commented] (AVRO-3051) Modernize C++ implementation

2021-02-27 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292292#comment-17292292 ] Thiruvalluvan M. G. commented on AVRO-3051: --- I've merged the PR:  

[jira] [Commented] (AVRO-3051) Modernize C++ implementation

2021-02-27 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292293#comment-17292293 ] Thiruvalluvan M. G. commented on AVRO-3051: --- This is next installment:

[jira] [Commented] (AVRO-3051) Modernize C++ implementation

2021-02-26 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291774#comment-17291774 ] Thiruvalluvan M. G. commented on AVRO-3051: --- If there is objection, I'll merge the pull request

[jira] [Commented] (AVRO-3194) [C++] Parsing avro file using `GenericDatum` results in segmentation fault

2021-09-01 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17408485#comment-17408485 ] Thiruvalluvan M. G. commented on AVRO-3194: --- [~OscarTHZhang] Is it possible to attach the

[jira] [Commented] (AVRO-2722) impl/DataFile.cc use of boost::mt19937 for DataFileWriteBase::makeSync is not thread safe

2021-10-31 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436593#comment-17436593 ] Thiruvalluvan M. G. commented on AVRO-2722: --- The cost of construction for the {{boost::mt19937}}

[jira] [Created] (AVRO-3510) PHP build fails on Travis

2022-05-01 Thread Thiruvalluvan M. G. (Jira)
Thiruvalluvan M. G. created AVRO-3510: - Summary: PHP build fails on Travis Key: AVRO-3510 URL: https://issues.apache.org/jira/browse/AVRO-3510 Project: Apache Avro Issue Type:

[jira] [Assigned] (AVRO-2870) DataFileWriterBase can throw in destructor

2022-04-29 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvalluvan M. G. reassigned AVRO-2870: - Assignee: Andrew Onyshchuk > DataFileWriterBase can throw in destructor >

[jira] [Resolved] (AVRO-2870) DataFileWriterBase can throw in destructor

2022-04-29 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvalluvan M. G. resolved AVRO-2870. --- Resolution: Fixed Merged the pull request. Thank you [~oandrew] > DataFileWriterBase

[jira] [Updated] (AVRO-3482) DataFileReader should reuse MAGIC data read from inputstream

2022-04-29 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvalluvan M. G. updated AVRO-3482: -- Fix Version/s: 1.11.1 > DataFileReader should reuse MAGIC data read from inputstream >

[jira] [Assigned] (AVRO-3482) DataFileReader should reuse MAGIC data read from inputstream

2022-04-29 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvalluvan M. G. reassigned AVRO-3482: - Assignee: Rajesh Balamohan (was: Thiruvalluvan M. G.) > DataFileReader should

[jira] [Resolved] (AVRO-3510) PHP build fails on Travis

2022-05-01 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvalluvan M. G. resolved AVRO-3510. --- Resolution: Fixed With the correct checksum, the build succeeds. > PHP build fails

[jira] [Commented] (AVRO-3482) DataFileReader should reuse MAGIC data read from inputstream

2022-05-01 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530594#comment-17530594 ] Thiruvalluvan M. G. commented on AVRO-3482: --- The fix is pushed to {{branch-1.11}} as well. >

[jira] [Commented] (AVRO-3510) PHP build fails on Travis

2022-05-03 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531461#comment-17531461 ] Thiruvalluvan M. G. commented on AVRO-3510: --- Thank you [~mgrigorov]for the permanent fix for the

[jira] [Assigned] (AVRO-3510) PHP build fails on Travis

2022-05-03 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvalluvan M. G. reassigned AVRO-3510: - Assignee: Martin Tzvetanov Grigorov (was: Thiruvalluvan M. G.) > PHP build

[jira] [Commented] (AVRO-3610) [C++] Upgrade from C++ 11 to C++ 17

2022-08-18 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17581624#comment-17581624 ] Thiruvalluvan M. G. commented on AVRO-3610: --- [~mgrigorov] I think that will be a great

[jira] [Resolved] (AVRO-3601) C++ API header contains breaking include

2022-08-11 Thread Thiruvalluvan M. G. (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvalluvan M. G. resolved AVRO-3601. --- Resolution: Fixed Merged the PR. Thanks a lot [~mgrigorov]. > C++ API header

<    2   3   4   5   6   7