Re: Better developer instructions for using Maven?

On Fri, Feb 10, 2017 at 11:54 AM, Davor Bonaci wrote: > I think Dan's framework of thinking is right -- what is the probability of > something finding a real issue, vs. the cost of running that all the time. > > Obviously, we cannot run *everything* all the time.

Re: Better developer instructions for using Maven?

I think Dan's framework of thinking is right -- what is the probability of something finding a real issue, vs. the cost of running that all the time. Obviously, we cannot run *everything* all the time. There's an infinite number of things to run and infinite matrix of configurations. Many tests

Re: Better developer instructions for using Maven?

Since the discussion has returned to the thread rather than Dan's PR, I want to paraphrase the point I feel strongest about here: *For a new contributor, I want to minimize the distance between them deciding to hack and becoming our friends.* So I don't want them to have to learn much, if

ToString Method Name

The ToString.of() violates the new transform rules and we need to choose a new name. Here is the method for reference: /** * Returns a {@code PTransform} which transforms each * element of the input {@link PCollection} to a {@link String} using the * {@link

Re: Better developer instructions for using Maven?

I'm with Dan on this. The iteration time should be cut down as low as possible and we have Jenkins to ensure that tests pass. As a side note, there are IntelliJ plugins for Checkstyle and Findbugs and my personal setup highlights Checkstyle violations as errors in the code so I can immediately

Re: Better developer instructions for using Maven?

On Feb 10, 2017 07:36, "Dan Halperin" wrote: Before we added checkstyle it was under a minute. Now it's over five? That's awful IMO Checkstyle didn't cause all that, did it? Noting that findbugs takes quite a lot more time. Javadoc and jar are the other two slow

Re: Better developer instructions for using Maven?

Opened JIRA ticket: https://issues.apache.org/jira/browse/BEAM-1457 On Fri, Feb 10, 2017 at 4:54 PM Jean-Baptiste Onofré wrote: > Yeah. Agree. Time extend is not huge and it's worth to add it in verify > phase. > > Regards > JB > > On Feb 10, 2017, 10:13, at 10:13, Aviem Zur

Re: Better developer instructions for using Maven?

Yeah. Agree. Time extend is not huge and it's worth to add it in verify phase. Regards JB On Feb 10, 2017, 10:13, at 10:13, Aviem Zur wrote: >This goes back to the original discussion in this thread - reduce the >amount of things pull requesters should know and keep the