Re: contributor permission for Beam Jira tickets

2019-09-08 Thread Agboola Mukhtar
Thank you very much! On 2019/09/08 05:25:38, Kenneth Knowles wrote: > Welcome! I have added you to the "Contributor" role so you can be assigned > Jiras. > > Kenn > > On Sat, Sep 7, 2019 at 9:06 PM Agboola Mukhtar > wrote: > > > Hi, > > I'm Agboola Mukhtar. I'm new to the world of open-sourc

Re: [DISCUSS] Supporting multiple Flink versions vs. tech debt

2019-09-08 Thread Kenneth Knowles
In my suggestion, there is no hacking around with source sets at all. There is no significant logic in the gradle configuration, which is a goal IMO. On Sun, Sep 8, 2019 at 3:15 AM Maximilian Michels wrote: > One minor addition, the "*1.5_to_1.7_utils" directory you listed, is > already present

Re: clickhouse tests failing

2019-09-08 Thread Lukasz Cwik
Is passing at head on Jenkins: https://builds.apache.org/job/beam_PreCommit_Java_Cron/1771/testReport/org.apache.beam.sdk.io.clickhouse/ What are the failures your seeing at initialization? (the tests do rely on setting up zookeeper and other stuff that could fail) On Fri, Sep 6, 2019 at 12:36 PM

Re: [DISCUSS] Supporting multiple Flink versions vs. tech debt

2019-09-08 Thread Thomas Weise
David, thanks for working on the Flink 1.9 support, this is very exciting! Previous discussion on list/PRs (predating even the JIRA referenced by Max), already pointed to the removal of support for Flink 1.5/1.6 support. Although we generally need to consider what the Beam users need (not just wha

Re: [DISCUSS] Supporting multiple Flink versions vs. tech debt

2019-09-08 Thread Maximilian Michels
One minor addition, the "*1.5_to_1.7_utils" directory you listed, is already present as the "1.5" directory. Admittedly, it could be renamed to make that clearer. * On 08.09.19 10:06, Maximilian Michels wrote: Thanks for your thoughts, David! Thanks Luke, copybara looks interesting. > Thomas

Re: [DISCUSS] Supporting multiple Flink versions vs. tech debt

2019-09-08 Thread Maximilian Michels
Thanks for your thoughts, David! Thanks Luke, copybara looks interesting. Thomas and Max expressed needs for addressing the issue with the current release. I think there is a misunderstanding. Thomas and I expressed the need to review the PR properly before merging it to avoid introducing t