arunpandianp commented on code in PR #17191:
URL: https://github.com/apache/beam/pull/17191#discussion_r841426413
##
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/GrpcWindmillServer.java:
##
@@ -632,6 +632,8 @@ private s
arunpandianp commented on code in PR #17191:
URL: https://github.com/apache/beam/pull/17191#discussion_r841426413
##
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/GrpcWindmillServer.java:
##
@@ -632,6 +632,8 @@ private s
On 4/2/22 16:41, Steve Niemitz wrote:
I've dug into this some more and have a couple observations/questions:
- I added some logging to my DoFn in both @ProcessElement
and @OnTimer, I can confirm that I never have late data coming into
ProcessElement (element.timestamp() is never after the end o
Oh I had forgotten about that thread, good point, it is very related to
this. I agree we should fix this, to force the conversation, I've opened a
PR to do so: https://github.com/apache/beam/pull/17262
As a good example of this behavior simply in the beam SDK, GroupIntoBatches
exhibits this proble
This is your daily summary of Beam's current flaky tests
(https://issues.apache.org/jira/issues/?jql=project%20%3D%20BEAM%20AND%20statusCategory%20!%3D%20Done%20AND%20labels%20%3D%20flake)
These are P1 issues because they have a major negative impact on the community
and make it hard to determin
This is your daily summary of Beam's current P1 issues, not including flaky
tests
(https://issues.apache.org/jira/issues/?jql=project%20%3D%20BEAM%20AND%20statusCategory%20!%3D%20Done%20AND%20priority%20%3D%20P1%20AND%20(labels%20is%20EMPTY%20OR%20labels%20!%3D%20flake).
See https://beam.apache.
Agreed, let's resolve the conversation in that PR and we should be good to
land it.
On Mon, Apr 4, 2022 at 5:15 PM Reuven Lax wrote:
> FYI - the bug you found is the one I was referring to. I actually had
> fixed this as part of a larger PR (that fixes bugs in DirectRunner), but to
> get this in
