Re: [VOTE] Vendored Dependencies Release

2024-01-19 Thread Robert Bradshaw via dev
Thanks. +1 On Fri, Jan 19, 2024 at 1:24 PM Yi Hu wrote: > The process I have been following is [1]. I have also suggested edits to > the voting email template to include the self-link. However, does anyone > can edit this doc so the change can be made? Otherwise we might better to > migrate

Re: @RequiresTimeSortedInput adoption by runners

2024-01-19 Thread Robert Bradshaw via dev
I think this standard design could still be made to work. Specifically, the graph would contain a DoFn that has the RequiresTimeSortedInput bit set, and as a single "subtransform" that has a different DoFn in its spec that does not require this bit to be set and whose implementation enforces this

Re: [VOTE] Vendored Dependencies Release

2024-01-19 Thread Yi Hu via dev
The process I have been following is [1]. I have also suggested edits to the voting email template to include the self-link. However, does anyone can edit this doc so the change can be made? Otherwise we might better to migrate this doc to

Re: @RequiresTimeSortedInput adoption by runners

2024-01-19 Thread Kenneth Knowles
In this design space, what we have done in the past is: 1) ensure that runners all reject pipelines they cannot run correctly 2) if there is a default/workaround/slower implementation, provide it as an override This is largely ignoring portability but I think/hope it will still work. At one time

Re: @RequiresTimeSortedInput adoption by runners

2024-01-19 Thread Robert Burke
I certainly don't have the deeper java insight here. So one more portable based reply and then I'll step back on the Java specifics. Portable runners only really have the "unknown Composite" fallback option, where if the Composite's URN isn't known to the runner, it should use the subgraph that

Re: @RequiresTimeSortedInput adoption by runners

2024-01-19 Thread Jan Lukavský
I was primarily focused on Java SDK (and core-contruction-java), but generally speaking, any SDK can provide default expansion that runners can use so that it is not (should not be) required to implement this manually. Currently, in Java SDK, the annotation is wired up into StatefulDoFnRunner,