Re: [PROPOSAL] Preparing for Beam release 2.40.0

2022-06-14 Thread Kenneth Knowles
I did a pass this morning. I believe there is only one release blocker that doesn't already have a fix. If I closed your issue or moved it off the milestone, feel free to have a different opinion and revert my action. Kenn On Mon, Jun 13, 2022 at 5:04 PM Ahmet Altay wrote: > > > On Tue, Jun 7,

Re: [PROPOSAL] Preparing for Beam release 2.40.0

2022-06-15 Thread Evan Galpin
RE https://github.com/apache/beam/issues/21690, I've just opened a PR with a fix: https://github.com/apache/beam/pull/21895. If that feels too rushed, I've also opened a PR to revert the change that introduced the regression in the first place: https://github.com/apache/beam/pull/21884. For Ela

Re: [PROPOSAL] Preparing for Beam release 2.40.0

2022-06-15 Thread Evan Galpin
> > Thank you Evan! How confident are you about the fix? > I validated the fix contained in #21895 against a job running in Dataflow that previously failed immediately (with the exact issue described in #21690

Re: [PROPOSAL] Preparing for Beam release 2.40.0

2022-06-15 Thread Vincent Marquez
Hello. I have a fix for https://github.com/apache/beam/issues/21715 here: https://github.com/apache/beam/pull/21786 Kenn mentioned that someone might want to get a fix in for it for the next release. It has not been reviewed or given feedback yet, but I thought I would let everyone know. *~Vin