Re: [RFC] State & Timers API Design for Go SDK

2022-08-04 Thread Robert Burke
Fantastic document! I have a much stronger idea of how state and timers are supposed to work generally by reading it. And the approach is very good, leveraging the new Go Generics in a reasonable way, without breaking the feel of the SDK. I can also see us adopting a similar technique more genera

Re: [RFC] State & Timers API Design for Go SDK

2022-07-28 Thread Austin Bennett
Looks great! On Thu, Jul 28, 2022 at 10:54 AM Jack McCluskey via dev wrote: > Great write-up on state and timers! The solution you chose feels very > in-line with how the Go SDK works. Make sure the design doc makes it onto > the wiki once you've addressed any feedback! > > On Thu, Jul 28, 2022

Re: [RFC] State & Timers API Design for Go SDK

2022-07-28 Thread Jack McCluskey via dev
Great write-up on state and timers! The solution you chose feels very in-line with how the Go SDK works. Make sure the design doc makes it onto the wiki once you've addressed any feedback! On Thu, Jul 28, 2022 at 1:49 PM Kerry Donny-Clark via dev < dev@beam.apache.org> wrote: > I think this a per

Re: [RFC] State & Timers API Design for Go SDK

2022-07-28 Thread Kerry Donny-Clark via dev
I think this a perfect example of a clear design doc. Great, deeply detailed alternatives considered and why they were rejected. This makes review easy, and lets us follow your thought process. I think this is a good implementation, and I support the chosen approach. Kerry On Thu, Jul 28, 2022 at

Re: [RFC] State & Timers API Design for Go SDK

2022-07-28 Thread Kenneth Knowles
Really thorough. Love it! On Thu, Jul 28, 2022 at 9:02 AM Ritesh Ghorse via dev wrote: > Hey everyone, > > Danny and I have been working on > designing the state and timers for Go SDK. We wrote a design doc with > user-facing API, execution details, and different alternatives considered. > It w

[RFC] State & Timers API Design for Go SDK

2022-07-28 Thread Ritesh Ghorse via dev
Hey everyone, Danny and I have been working on designing the state and timers for Go SDK. We wrote a design doc with user-facing API, execution details, and different alternatives considered. It would be really helpful if we could get your suggestions/feedback/comments on the design. Design Doc: