Re: [SQL] Windowing and triggering changes proposal

2018-01-19 Thread Tyler Akidau
I'm late to the party as usual, but also added some comments. Overall supportive of this work. Thanks for the clear analysis, Anton. On Tue, Jan 16, 2018 at 10:58 AM Mingmin Xu wrote: > Thanks @Anton for the proposal. Window(w/ trigger) support in SQL is > limited now, you're very welcome to joi

Re: [SQL] Windowing and triggering changes proposal

2018-01-16 Thread Mingmin Xu
Thanks @Anton for the proposal. Window(w/ trigger) support in SQL is limited now, you're very welcome to join the improvement. There's a balance between injected DSL mode and CLI mode when we were implementing BealmSQL overall, not only widowing. Many default behaviors are introduced to make it wo

Re: [SQL] Windowing and triggering changes proposal

2018-01-16 Thread Kenneth Knowles
I've commented on the doc. This is a really nice analysis and I think the proposal is good for making SQL work with Beam windowing and triggering in a way that will make sense to users. Kenn On Thu, Jan 11, 2018 at 4:05 PM, Anton Kedin wrote: > Hi, > > Wanted to gather feedback on changes I pro

[SQL] Windowing and triggering changes proposal

2018-01-11 Thread Anton Kedin
Hi, Wanted to gather feedback on changes I propose to the behavior of some aspects of windowing and triggering in Beam SQL. In short: Beam SQL currently overrides input PCollections' windowing/triggering configuration in few cases. For example if a query has a simple GROUP BY clause, we would ap