Re: [Testing] Splitting pre-commits from post-commit test targets

2018-11-20 Thread Rui Wang
Useful and really practical idea! -Rui On Tue, Nov 20, 2018 at 10:37 AM Ruoyun Huang wrote: > +1 Great improvement! Thanks Scott! > > On Tue, Nov 20, 2018 at 10:33 AM Pablo Estrada wrote: > >> I think this is a great idea, and a good improvement. Thanks Scott! >> -P. >> >> On Tue, Nov 20, 201

Re: [Testing] Splitting pre-commits from post-commit test targets

2018-11-20 Thread Ruoyun Huang
+1 Great improvement! Thanks Scott! On Tue, Nov 20, 2018 at 10:33 AM Pablo Estrada wrote: > I think this is a great idea, and a good improvement. Thanks Scott! > -P. > > On Tue, Nov 20, 2018 at 10:09 AM Scott Wegner wrote: > >> I wanted to give a heads-up to a small optimization that I hope to

Re: [Testing] Splitting pre-commits from post-commit test targets

2018-11-20 Thread Pablo Estrada
I think this is a great idea, and a good improvement. Thanks Scott! -P. On Tue, Nov 20, 2018 at 10:09 AM Scott Wegner wrote: > I wanted to give a heads-up to a small optimization that I hope to make to > our Jenkins test targets. Currently our post-commit test jobs also > redundantly run pre-com

[Testing] Splitting pre-commits from post-commit test targets

2018-11-20 Thread Scott Wegner
I wanted to give a heads-up to a small optimization that I hope to make to our Jenkins test targets. Currently our post-commit test jobs also redundantly run pre-commit tests. I'd like to remove redundant execution to get a faster post-commit test signal. See: https://github.com/apache/beam/pull/70