Re: [VOTE] Patch Release 2.55.1, release candidate #2

2024-04-03 Thread Robert Bradshaw via dev
+1 (binding) The artifacts all look good to me. On Wed, Apr 3, 2024 at 1:35 PM XQ Hu via dev wrote: > +1 (non-binding). Tested this using a simple Dataflow ML pipeline: > https://github.com/google/dataflow-ml-starter/actions/runs/8541848483. > > On Wed, Apr 3, 2024 at 2:35 PM Jeff Kinard wrote:

Re: [VOTE] Patch Release 2.55.1, release candidate #2

2024-04-03 Thread XQ Hu via dev
+1 (non-binding). Tested this using a simple Dataflow ML pipeline: https://github.com/google/dataflow-ml-starter/actions/runs/8541848483. On Wed, Apr 3, 2024 at 2:35 PM Jeff Kinard wrote: > +1. Validated running from local gradle JAR and staged maven JAR for > expansion-service. > > On Wed, Apr

Re: [VOTE] Patch Release 2.55.1, release candidate #2

2024-04-03 Thread Jeff Kinard
+1. Validated running from local gradle JAR and staged maven JAR for expansion-service. On Wed, Apr 3, 2024 at 11:08 AM Danny McCormick via dev wrote: > Hi everyone, > > I put together a patch release per the conversation in > https://lists.apache.org/thread/kvq1wsj505pvopkq186dnvc0l6ryyfh0. > >

Re: [VOTE] Patch Release 2.55.1, release candidate #2

2024-04-03 Thread Kenneth Knowles
+1 (binding) Kenn On Wed, Apr 3, 2024 at 12:58 PM Danny McCormick via dev wrote: > > Also noting that there is no PR postsubmit test suite running against > the release branch in the vote email. Given the diff, that's also fine > since previous tests runs didn't detect the breakage, but in gene

Re: [VOTE] Patch Release 2.55.1, release candidate #2

2024-04-03 Thread Danny McCormick via dev
> Also noting that there is no PR postsubmit test suite running against the release branch in the vote email. Given the diff, that's also fine since previous tests runs didn't detect the breakage, but in general we should include that for patch releases as well. Yeah, it didn't seem useful to run

Re: [VOTE] Patch Release 2.55.1, release candidate #2

2024-04-03 Thread Valentyn Tymofieiev via dev
Hi Danny, Thanks for volunteering to do this patch release. For review convenience, this is the diff: - Diff of release branches: https://github.com/apache/beam/compare/release-2.55.0...release-2.55.1 - The diff of tags v2.55.0-RC3 and v2.55.1-RC2: https://github.com/apache/beam/compare/v2.55

[VOTE] Patch Release 2.55.1, release candidate #2

2024-04-03 Thread Danny McCormick via dev
Hi everyone, I put together a patch release per the conversation in https://lists.apache.org/thread/kvq1wsj505pvopkq186dnvc0l6ryyfh0. Please review and vote on the release candidate #2 (I messed up rc1) for the version 2.55.1, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the rel