Re: [VOTE] Release 2.47.0, release candidate #1

2023-04-28 Thread Jack McCluskey via dev
The move to support and require protobuf v4 in the python SDK has inadvertently broken downstream users who depend on Beam, who have asked if that requirement can be lowered to also allow protobuf v3. Further investigation has determined that the lower bounds of this requirement can be relaxed with

Re: [VOTE] Release 2.47.0, release candidate #1

2023-04-28 Thread Alexey Romanenko
+1 (binding) Tested with https://github.com/Talend/beam-samples/ (Java SDK v8/v11/v17, Spark 3.x runner). --- Alexey > On 28 Apr 2023, at 16:06, Jack McCluskey via dev wrote: > > There was a GCP outage that impacted pushing containers to GCR, I expected it > to impact Java containers specif

Re: [VOTE] Release 2.47.0, release candidate #1

2023-04-28 Thread Jack McCluskey via dev
There was a GCP outage that impacted pushing containers to GCR, I expected it to impact Java containers specifically but it looks like it also affected Python containers. I believe the situation is resolved and I can get the containers pushed now, if that continues to be an issue I'll follow up. O

Re: [VOTE] Release 2.47.0, release candidate #1

2023-04-27 Thread Chamikara Jayalath via dev
I tried to run a Java multi-lang pipeline and it's failing due to the following error during worker setup. Error syncing pod, skipping" err="failed to \"StartContainer\" for \"sdk-1-0\" with ImagePullBackOff: \"Back-off pulling image \\\" gcr.io/cloud-dataflow/v1beta3/beam_python3.8_sdk:2.47.0\\\"

Re: [VOTE] Release 2.47.0, release candidate #1

2023-04-27 Thread Robert Bradshaw via dev
The artifacts and signatures all look good, and I validated a couple of Python pipelines in a fresh install. Assuming all the tests (including the Dataflow ones) pass (modulo the two mentioned above; seems a fair justification to not block on those) I'm +1 (binding) on this release. On Wed, Apr 2

Re: [VOTE] Release 2.47.0, release candidate #1

2023-04-26 Thread Jack McCluskey via dev
There's also a good chance that newer test suites haven't been included in mass_comment.py ( https://github.com/apache/beam/blob/master/release/src/main/scripts/mass_comment.py) and as a result they were not executed. On Wed, Apr 26, 2023 at 3:29 PM Jack McCluskey wrote: > The Dataflow CrossLang

Re: [VOTE] Release 2.47.0, release candidate #1

2023-04-26 Thread Jack McCluskey via dev
The Dataflow CrossLanguageValidatesRunner GoUsingJava Tests have been broken for quite some time (https://github.com/apache/beam/issues/21645) and the Kafka issue is tied to a test timeout that John Casey has fixed but didn't get cherrypicked (just fell through the cracks while waiting on tests to

Re: [VOTE] Release 2.47.0, release candidate #1

2023-04-26 Thread Valentyn Tymofieiev via dev
Thanks, Jack! re [12]: I am seeing some test errors - have they been investigated? Also, did all test suites run? I think I am not seeing output of some of the suites, like Run Python Dataflow V2 ValidatesRunner On Wed, Apr 26, 2023 at 9:14 PM Jack McCluskey via dev wrote: > Hi everyone, >

[VOTE] Release 2.47.0, release candidate #1

2023-04-26 Thread Jack McCluskey via dev
Hi everyone, Please review and vote on the release candidate #3 for the version 1.2.3, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) Reviewers are encouraged to test their own use cases with the release candidate, and vote +1 if no i