Re: Convert Row with nullable fields to Protobuf fails

2021-12-18 Thread Jozef Vilcek
Any feedback on this one please? On Mon, Dec 13, 2021 at 11:02 AM Jozef Vilcek wrote: > Yes, field is marked as nullable. Here is a test case change to > illustrate it: > > https://github.com/JozoVilcek/beam/commit/5e1c6324868c2fd6145dd2348c7358fdc787ac38 > > On Sun, Dec 12, 2021 at 7:28 PM Reuv

Re: Convert Row with nullable fields to Protobuf fails

2021-12-13 Thread Jozef Vilcek
Yes, field is marked as nullable. Here is a test case change to illustrate it: https://github.com/JozoVilcek/beam/commit/5e1c6324868c2fd6145dd2348c7358fdc787ac38 On Sun, Dec 12, 2021 at 7:28 PM Reuven Lax wrote: > Is the schema field marked as nullable? > > On Sun, Dec 12, 2021 at 4:21 AM Jozef

Convert Row with nullable fields to Protobuf fails

2021-12-12 Thread Jozef Vilcek
I did notice that protobuf schema translator supports nullable for proto fiels [1]. E.g. if I want to a nullable string, then in proto I can use `google.protobuf.StringValue` and schema will look fine. However, fromRow creator does not support this and throw exception if it is presented with row i