Re: Cross-language transform API

2019-03-12 Thread Reuven Lax
About schemas, pr/7952 adds schemas to the runner API. This PR focuses on the Dataflow runner (not the portability runner). However after some community discussion on the design (we are still free to change these protos based on discussion), I would like to stabilize these protos. On Mon, Mar 11,

Re: Cross-language transform API

2019-03-11 Thread Maximilian Michels
Thanks for the remarks. Correct, we do not need the static URN at all in the payload. We can pass the transform URN with the ExternalTransform as part of the ExpansionRequest. So this is sufficient for the Proto: message ConfigValue { string coder_urn = 1; bytes payload = 2; } message Exte

Re: Cross-language transform API

2019-03-11 Thread Robert Bradshaw
On Mon, Mar 11, 2019 at 6:05 PM Chamikara Jayalath wrote: > > On Mon, Mar 11, 2019 at 9:27 AM Robert Bradshaw wrote: >> >> On Mon, Mar 11, 2019 at 4:37 PM Maximilian Michels wrote: >> > >> > > Just to clarify. What's the reason for including a PROPERTIES enum here >> > > instead of directly mak

Re: Cross-language transform API

2019-03-11 Thread Chamikara Jayalath
On Mon, Mar 11, 2019 at 9:27 AM Robert Bradshaw wrote: > On Mon, Mar 11, 2019 at 4:37 PM Maximilian Michels wrote: > > > > > Just to clarify. What's the reason for including a PROPERTIES enum > here instead of directly making beam_urn a field of > ExternalTransformPayload ? > > > > The URN is su

Re: Cross-language transform API

2019-03-11 Thread Robert Bradshaw
On Mon, Mar 11, 2019 at 4:37 PM Maximilian Michels wrote: > > > Just to clarify. What's the reason for including a PROPERTIES enum here > > instead of directly making beam_urn a field of ExternalTransformPayload ? > > The URN is supposed to be static. We always use the same URN for this > type of