Re: JUnit 5 review

Hi Kenneth, issue is JUnit 5 is not JUnit 4 +1, it is another project (like TestNG is) so migration is not even an option. My goal in the PR was to enable people using JUnit 5 as a base framework to test beam pipelines and be able to reuse all their tooling goodness like this extension https://tal

Re: JUnit 5 review

As open source, IMO it is fine to do something just because you are interested, as long as it works in the interest of the project. I'm not opposed, but there isn't enough information yet. I would like to see a design document about the differences between JUnit 4 and 5 and how that will affect Be

Re: JUnit 5 review

Great, thanks ! We will resume our review here once Beam 2.3.0 is out. Regards JB On 01/23/2018 10:28 AM, Romain Manni-Bucau wrote: > Oki JB, > > Will implement it on my side until beam supports it then. > > Thanks for the feedback. > > > Romain Manni-Bucau > @rmannibucau

Re: JUnit 5 review

Oki JB, Will implement it on my side until beam supports it then. Thanks for the feedback. Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | Link

Re: JUnit 5 review

Hi Romain, Definitely it's not something targeted for Beam 2.3.0. It's interesting, but it sounds a bit like a lonesome cowboy effort. I think it would have been great to discuss a bit in term of priority (on the mailing list) before rushing on the PR. Couple of highlights in the Jira or PR woul

JUnit 5 review

Hi guys, Anyone able to have a look to the JUnit 5 PR ( https://github.com/apache/beam/pull/4360)? Worse case a "yes we'll move this direction" or "no we don't care about JUnit 5 for now" feedback would be very valuable for me. Thanks, Romain Manni-Bucau @rmannibucau