Re: Merging Python code? Help avoid Python 3 regressions with these two simple steps :)

To address the first point, 3.4 is almost certainly sufficient for our needs (running lint_py3 to prevent regressions). Also, +1 that automating this is going to be much more effective than asking users to manually do extra steps. Long-term, we should definitely support 3.5+, definitely not

Re: Merging Python code? Help avoid Python 3 regressions with these two simple steps :)

3.4.3 is from Feb 2015, and for what it’s worth the minimum version of Python in Spark is 3.4. We could enable lint tests in Jenkins and see how they go? On Fri, Mar 2, 2018 at 10:06 AM Alan Myrvold wrote: > I ran "python3 --version" on each worker and all showed python

Re: Merging Python code? Help avoid Python 3 regressions with these two simple steps :)

I ran "python3 --version" on each worker and all showed python 3.4.3. Is that too old? On Fri, Mar 2, 2018 at 10:04 AM Ahmet Altay wrote: > That is my understanding as well, it is requires attention from infra. > Could anyone help with this? I know we worked with infra

Re: Merging Python code? Help avoid Python 3 regressions with these two simple steps :)

That is my understanding as well, it is requires attention from infra. Could anyone help with this? I know we worked with infra before, what is the best way to approach this? On Fri, Mar 2, 2018 at 9:50 AM, Holden Karau wrote: > I agree, however I'm of the impression

Re: Merging Python code? Help avoid Python 3 regressions with these two simple steps :)

I agree, however I'm of the impression it's blocked on infra? (e.g. it's important but out of my hands). On Mar 1, 2018 11:05 PM, "Ahmet Altay" wrote: > I think we should prioritize the issue of installing Python 3 on the > workers

Re: Merging Python code? Help avoid Python 3 regressions with these two simple steps :)

I think we should prioritize the issue of installing Python 3 on the workers (https://issues.apache.org/jira/browse/BEAM-3671). I would appreciate if folks pay attention to these 2 steps but I am worried that it will be easily forgotten. On Thu, Mar 1, 2018 at 6:51 PM, Holden Karau

Merging Python code? Help avoid Python 3 regressions with these two simple steps :)

I may have watched too many buzzfeed videos this week but the steps are: 1) git checkout the PR in question 2) Run tox -e lint_py2,lint_py3 This is important since Python 3 isn't installed on the Jenkins workers just yet and we have some tests to catch basic invalid Python 3 which we can slowly