Precommits fire for wrong PRs

2019-12-05 Thread Michał Walenia
Hi all, I noticed that sometimes the precommit jobs are launched for unrelated PRs, eg. Python or website precommit runs for some Java and gradle changes. AFAIK, the 'responsibility regions' for the jobs are defined in Job DSL scripts and are regexes that file changed paths are checked against. for

Re: Precommits fire for wrong PRs

2019-12-09 Thread Kenneth Knowles
One reason it would trigger is that it modified buildSrc/.../BeamModulePlugin.groovy Edits there are rare. But if it is a problem, each of the "applyXYZNature" methods could and probably should be moved to a separate plugin, maybe with a little work. Kenn On Thu, Dec 5, 2019 at 2:38 AM Michał Wa