Re: Python 3: final step

2019-01-09 Thread Robbe Sneyders
Hi all, We've been making quite some progress these last weeks. I'll give a short status update on where we are right now. Our current goal is to make all unittests succeed in Python 3. We are currently at: 1842 tests: (SKIP=350, errors=100, failures=9) All of these remaining errors and

Re: Python 3: final step

2019-01-07 Thread Ahmet Altay
+Matthias Feys +Valentyn Tymofieiev +Mark Liu could add more details here since they are working on Python 3 for a while now. Hopeful state is that we might have python 3 working with DirectRunner in the release after this one (2.12). Mark is also working on getting python 3 working on a

Re: Python 3: final step

2019-01-07 Thread Maximilian Michels
Also curious because I see Python 3 requests quite often. I always say, we're close, but how close are we? :) Thanks, Max On 05.01.19 00:03, Manu Zhang wrote: Guys, Happy New Year !!! I haven't got much time to contribute to Python 3 support. What is the progress now ? It seems there are

Re: Python 3: final step

2019-01-04 Thread Manu Zhang
Guys, Happy New Year !!! I haven't got much time to contribute to Python 3 support. What is the progress now ? It seems there are quite a few open issues under https://issues.apache.org/jira/browse/BEAM-1251. People have kept asking about Python 3 support in tf.transform (

Re: Python 3: final step

2018-10-11 Thread Valentyn Tymofieiev
I cc'ed a few folks who are familiar with Jenkins setup on https://issues.apache.org/jira/browse/BEAM-5663, I think we can continue the discussion there or start a separate thread. On Wed, Oct 10, 2018 at 8:54 PM Manu Zhang wrote: > Does anyone know how to set up python version on Jenkins ?

Re: Python 3: final step

2018-10-10 Thread Manu Zhang
Does anyone know how to set up python version on Jenkins ? It’s Python 3.5.2 now. Thanks, Manu Zhang On Oct 5, 2018, 9:24 AM +0800, Valentyn Tymofieiev , wrote: > I have put together a guide [1] to help get started with investigating Python > 3-related test failures that may be helpful for new

Re: Python 3: final step

2018-10-04 Thread Valentyn Tymofieiev
I have put together a guide [1] to help get started with investigating Python 3-related test failures that may be helpful for new folks joining the effort. Comments and improvements welcome! Thanks, Valentyn [1] https://docs.google.com/document/d/1s1BJVCY65LB_SYK1SU1u7NbZiFANoq-nEYaEvzRbYlA

Re: Python 3: final step

2018-10-04 Thread Valentyn Tymofieiev
I agree there is some overlap between JIRAs that track individual failures and module-level JIRAs. We originally wanted to do the conversion on a module-by-module basis, however we learned that test failures in some modules require changes in other modules, and it may be a little easier to slice

Re: Python 3: final step

2018-10-03 Thread Manu Zhang
Thanks Valentyn. Note some test failing issues are covered by “Finish Python 3 porting for *** module”, e.g. https://issues.apache.org/jira/browse/BEAM-5315. Manu 在 2018年10月3日 +0800 PM4:18,Valentyn Tymofieiev ,写道: > Hi Rakesh and Manu, > > Thanks to both of you for offering help (in different

Re: Python 3: final step

2018-10-03 Thread Valentyn Tymofieiev
Hi Rakesh and Manu, Thanks to both of you for offering help (in different threads). It's great to see that more and more people get involved with helping to make Beam Python 3 compatible! There are a few PRs in flight, and several people in the community actively work on Python 3 support now. I

Re: Python 3: final step

2018-10-02 Thread Pablo Estrada
Very cool : ) I'm also available to review / merge if you need help from my side. Best -P. On Tue, Oct 2, 2018 at 7:45 AM Rakesh Kumar wrote: > Hi Rob, > > I am, Rakesh Kumar, using Beam SDK for one of my projects at Lyft. I have > been working closely with Thomas Weise. I have already met a

Re: Python 3: final step

2018-10-02 Thread Rakesh Kumar
Hi Rob, I am, Rakesh Kumar, using Beam SDK for one of my projects at Lyft. I have been working closely with Thomas Weise. I have already met a couple of Python SDK developers in person. I am interested to help migrate to Python 3. You can assign me PRs for review. I am also more than happy to

Re: Python 3: final step

2018-09-07 Thread Maximilian Michels
This has been requested multiple times. Thanks for working on the Python 3 story. Let me know if I can help out in any way! On 05.09.18 19:01, Valentyn Tymofieiev wrote: This is awesome! Kudos to Robbe and Matthias who have been pushing this forward! On Wed, Sep 5, 2018 at 9:45 AM Charles

Re: Python 3: final step

2018-09-05 Thread Valentyn Tymofieiev
This is awesome! Kudos to Robbe and Matthias who have been pushing this forward! On Wed, Sep 5, 2018 at 9:45 AM Charles Chen wrote: > This is great! Feel free to add me as a reviewer. > > On Wed, Sep 5, 2018 at 9:38 AM Andrew Pilloud wrote: > >> Cool! I know very little about Python 3, but

Re: Python 3: final step

2018-09-05 Thread Charles Chen
This is great! Feel free to add me as a reviewer. On Wed, Sep 5, 2018 at 9:38 AM Andrew Pilloud wrote: > Cool! I know very little about Python 3, but happy to help review. > > Andrew > > On Wed, Sep 5, 2018 at 9:21 AM Ahmet Altay wrote: > >> Thank you Robbe, this is great news! >> >> On Wed,

Re: Python 3: final step

2018-09-05 Thread Andrew Pilloud
Cool! I know very little about Python 3, but happy to help review. Andrew On Wed, Sep 5, 2018 at 9:21 AM Ahmet Altay wrote: > Thank you Robbe, this is great news! > > On Wed, Sep 5, 2018 at 9:11 AM, Robbe Sneyders > wrote: > >> Hi everyone, >> >> With the merging of [1], we now have Python 3

Re: Python 3: final step

2018-09-05 Thread Ahmet Altay
Thank you Robbe, this is great news! On Wed, Sep 5, 2018 at 9:11 AM, Robbe Sneyders wrote: > Hi everyone, > > With the merging of [1], we now have Python 3 tests running on Jenkins, > which allows us to move forward with the last step of the Python 3 porting. > > You can follow the progress on

Python 3: final step

2018-09-05 Thread Robbe Sneyders
Hi everyone, With the merging of [1], we now have Python 3 tests running on Jenkins, which allows us to move forward with the last step of the Python 3 porting. You can follow the progress on the Jira Kanban Board [2]. If you're interested in helping by porting a module, you can assign one of