Re: Questions about the current and future design of the job service message stream

2019-11-11 Thread Luke Cwik
On Sun, Nov 10, 2019 at 5:06 PM Chad Dombrova wrote: > Hi, > >> You can see that each JobMessagesResponse may contain a message *or* a >>> GetJobStateResponse. >>> >>> What’s the intention behind this design? >>> >> I believe this was because a user may want to listen to both job state >> and mes

Re: Questions about the current and future design of the job service message stream

2019-11-10 Thread Chad Dombrova
Hi, > You can see that each JobMessagesResponse may contain a message *or* a >> GetJobStateResponse. >> >> What’s the intention behind this design? >> > I believe this was because a user may want to listen to both job state and > messages all in one stream. > Just to be crystal clear, what's the

Re: Questions about the current and future design of the job service message stream

2019-11-08 Thread Luke Cwik
+Daniel Mills for usability in job messages / logging integration across Beam runners. On Wed, Nov 6, 2019 at 10:30 AM Chad Dombrova wrote: > Hi all, > I’ve been working lately on improving the state stream and message stream > on the job service (links to issues and PRs below), and I’m somewha

Questions about the current and future design of the job service message stream

2019-11-06 Thread Chad Dombrova
Hi all, I’ve been working lately on improving the state stream and message stream on the job service (links to issues and PRs below), and I’m somewhat confused by the inclusion of states in the message stream, since there’s a separate dedicated state stream for that. Here’s the proto for the messag