Re: Rebuilding beam before running Performance Test - question.

2018-04-17 Thread Łukasz Gajowy
ok, fyi I created a PR for this here: https://github.com/apache/beam/pull/5153 2018-04-16 19:40 GMT+02:00 Jason Kuster : > I think that should be fine; I believe the way it was that way originally > was because we already had things set up for building in Jenkins, but it > was a while ago. Given

Re: Rebuilding beam before running Performance Test - question.

2018-04-16 Thread Jason Kuster
I think that should be fine; I believe the way it was that way originally was because we already had things set up for building in Jenkins, but it was a while ago. Given the performance tests run infrequently enough, I don't think an increase in runtime will be a big deal. On Mon, Apr 16, 2018 at

Rebuilding beam before running Performance Test - question.

2018-04-16 Thread Łukasz Gajowy
Hi all, currently performance tests running on Jenkins all have "beam_prebuilt" [1] Perfkit's flag set to true, which means that PerfKit does not rebuild the code before invoking the Performance Test. This makes things faster but error prone - we observed Performance Tests failures several times d