Re: SchemaTransformProvider | Java class naming convention

2022-11-15 Thread Chamikara Jayalath via dev
On Tue, Nov 15, 2022 at 12:52 PM Ahmed Abualsaud wrote: > Schema-aware transforms are not restricted to I/Os. An arbitrary transform >> can be a Schema-Transform. Also, designation Read/Write does not map to an >> arbitrary transform. Probably we should try to make this more generic ? >> > > Agr

Re: SchemaTransformProvider | Java class naming convention

2022-11-15 Thread Chamikara Jayalath via dev
On Tue, Nov 15, 2022 at 1:38 PM Reuven Lax via dev wrote: > Out of curiosity, several IOs (including PubSub) already do support > schemas. Are you planning on modifying those? > Schema-aware Transform is an overloaded term. I think this is about the implementations of the following. https://docs

Re: SchemaTransformProvider | Java class naming convention

2022-11-15 Thread Reuven Lax via dev
Out of curiosity, several IOs (including PubSub) already do support schemas. Are you planning on modifying those? On Tue, Nov 15, 2022 at 11:50 AM Damon Douglas via dev wrote: > Hello Everyone, > > Do we like the following Java class naming convention for > SchemaTransformProviders [1]? The pro

Re: SchemaTransformProvider | Java class naming convention

2022-11-15 Thread Ahmed Abualsaud via dev
> > Schema-aware transforms are not restricted to I/Os. An arbitrary transform > can be a Schema-Transform. Also, designation Read/Write does not map to an > arbitrary transform. Probably we should try to make this more generic ? > Agreed, I suggest keeping everything on the left side of the name

Re: SchemaTransformProvider | Java class naming convention

2022-11-15 Thread John Casey via dev
One distinction here is the difference between the URN for a provider / transform, and the class name in Java. We should have a standard for both, but they are distinct On Tue, Nov 15, 2022 at 3:39 PM Chamikara Jayalath via dev < dev@beam.apache.org> wrote: > > > On Tue, Nov 15, 2022 at 11:50 AM

Re: SchemaTransformProvider | Java class naming convention

2022-11-15 Thread Chamikara Jayalath via dev
On Tue, Nov 15, 2022 at 11:50 AM Damon Douglas via dev wrote: > Hello Everyone, > > Do we like the following Java class naming convention for > SchemaTransformProviders [1]? The proposal is: > > (Read|Write)SchemaTransformProvider > > > *For those new to Beam, even if this is your first day, con

Re: SchemaTransformProvider | Java class naming convention

2022-11-15 Thread Ahmed Abualsaud via dev
Thank you for the informative email Damon! I am in favor of setting an intuitive naming convention early on to reduce confusion when Schema Transforms become more widespread. I like the proposed name in your email and I think this convention should also apply to the rest of the classes involved her

SchemaTransformProvider | Java class naming convention

2022-11-15 Thread Damon Douglas via dev
Hello Everyone, Do we like the following Java class naming convention for SchemaTransformProviders [1]? The proposal is: (Read|Write)SchemaTransformProvider *For those new to Beam, even if this is your first day, consider yourselves a welcome contributor to this conversation. Below are defini