Re: Should WindowFn have a mininal Duration?

2021-04-26 Thread Jan Lukavský
Hi Robert and Reuven, I was not aware that implementing custom windowing logic is that much "common" practice. If so, I think that probably makes little sense to "force" users specify the minimal duration - though it could be made somewhat "user-friendly", but still, it would require some

Re: Should WindowFn have a mininal Duration?

2021-04-26 Thread Reuven Lax
I've often seen custom windowfns with no static minimum duration. e.g. a common customization of sessions is to identify a specific "logout" event to end the session. On Mon, Apr 26, 2021 at 11:08 AM Robert Bradshaw wrote: > I do think minimal window duration is a meaningful concept for >

Re: Should WindowFn have a mininal Duration?

2021-04-26 Thread Robert Bradshaw
I do think minimal window duration is a meaningful concept for WindowFns, but from the pragmatic perspective I would ask is it useful enough to require all implementers of WindowFn to specify it (given that a default value of 0 would not be very useful). On Mon, Apr 26, 2021 at 10:05 AM Jan

Re: Should WindowFn have a mininal Duration?

2021-04-26 Thread Jan Lukavský
Hi Kenn, On 4/26/21 5:59 PM, Kenneth Knowles wrote: In +Reza Rokni 's example of looping timers, it is necessary to "seed" each key, for just the reason you say. The looping timer itself for a key should be in the global window. The outputs of the looping timer

Re: Should WindowFn have a mininal Duration?

2021-04-26 Thread Kenneth Knowles
In +Reza Rokni 's example of looping timers, it is necessary to "seed" each key, for just the reason you say. The looping timer itself for a key should be in the global window. The outputs of the looping timer are windowed. All that said, your example seems possibly easier if you are OK with no

Should WindowFn have a mininal Duration?

2021-04-22 Thread Jan Lukavský
Hi, I have come across a "problem" while implementing some toy Pipeline. I would like to split input PCollection into two parts - droppable data (delayed for more than allowed lateness from the end of the window) from the rest. I will not go into details, as that is not relevant, the problem