Re: Testing code in extensions against runner

2019-06-24 Thread Reza Rokni
So if I understood correctly; Emulate the SQL precommit / postcommit extension and incorporate running the test against different runners. Would be snazzy indeed! A bit beyond my skill set I fear :-) On Wed, 19 Jun 2019 at 10:34, Kenneth Knowles wrote: > Slight point here: @ValidatesRunner sho

Re: Testing code in extensions against runner

2019-06-18 Thread Kenneth Knowles
Slight point here: @ValidatesRunner should only be for tests that the runner implements the core model. Also, outside of the SDK core, you don't need it. If you use TestPipeline it already picks up the config for what runner. So all you need is to use TestPipeline and add it to some suite of tests

Re: Testing code in extensions against runner

2019-06-18 Thread Reza Rokni
Thanx! It would definitely be great to have the ability for folks adding utility / extensions to be able to have them run against all runners. Cheers Reza On Fri, 7 Jun 2019, 19:05 Lukasz Cwik, wrote: > We have been currently been having every runner define and manage its own > suite/tests so

Re: Testing code in extensions against runner

2019-06-07 Thread Lukasz Cwik
We have been currently been having every runner define and manage its own suite/tests so yes modifying flink_runner.gradle is currently the correct thing to do. There is a larger discussion about whether this is the right way since we would like to capture things like perf benchmarks and validates

Testing code in extensions against runner

2019-06-06 Thread Reza Rokni
Hi, I would like to validate some code that I am building under extensions against different runners. It makes use of some caches in a DoFn which are a little off the beaten path. I have added @ValidatesRunner to the class and by adding the right values to the gradle file in flink_runner have got