Re: compileTestJava broken on master

2019-02-22 Thread Reuven Lax
pr/7930 if you want to review. On Fri, Feb 22, 2019 at 12:02 PM Reuven Lax wrote: > FYI, it looks like what happened is that the final commit in that PR > didn't get pushed ti github before merging. Verifying locally and sending > you a PR to fix this. > > On Fri, Feb 22, 2019 at 11:56 AM Reuven

Re: compileTestJava broken on master

2019-02-22 Thread Reuven Lax
FYI, it looks like what happened is that the final commit in that PR didn't get pushed ti github before merging. Verifying locally and sending you a PR to fix this. On Fri, Feb 22, 2019 at 11:56 AM Reuven Lax wrote: > Sending a fix right now. > > On Fri, Feb 22, 2019 at 11:49 AM Ryan Williams >

Re: compileTestJava broken on master

2019-02-22 Thread Reuven Lax
Sending a fix right now. On Fri, Feb 22, 2019 at 11:49 AM Ryan Williams wrote: > I sent a revert at #7928 in > case anyone wants to take a look > > On Fri, Feb 22, 2019 at 2:39 PM Ryan Williams > wrote: > >> AFAICT #7635 was merged with compileTestJava

Re: compileTestJava broken on master

2019-02-22 Thread Ryan Williams
I sent a revert at #7928 in case anyone wants to take a look On Fri, Feb 22, 2019 at 2:39 PM Ryan Williams wrote: > AFAICT #7635 was merged with compileTestJava failures > , > and com

compileTestJava broken on master

2019-02-22 Thread Ryan Williams
AFAICT #7635 was merged with compileTestJava failures , and compileTestJava is broken on master now. My guess is it was thought that the Java PreCommit failure was due to the flaky Kudu test (which also failed in the build in qu