Re: force the coder for a pardo

2018-02-20 Thread Romain Manni-Bucau
+1 if nobody beats me at it I can have a look next week probably - but happy to let somebody else have fun too ;) Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github

Re: force the coder for a pardo

2018-02-20 Thread Jean-Baptiste Onofré
Agree. It makes sense to me in order to be consistent between the PTransforms. Regards JB Le 20 févr. 2018 à 16:08, à 16:08, Eugene Kirpichov a écrit: >Something similar was discussed a while ago, and lead to the suggestion >in >PTransform Style Guide: >https://beam.apache.org/contribute/ptrans

Re: force the coder for a pardo

2018-02-20 Thread Eugene Kirpichov
Something similar was discussed a while ago, and lead to the suggestion in PTransform Style Guide: https://beam.apache.org/contribute/ptransform-style-guide/#setting-coders-on-output-collections This suggestion is currently not followed by ParDo, but your plan moves in that direction, so +1 to tha

Re: force the coder for a pardo

2018-02-20 Thread Jean-Baptiste Onofré
Got the point. No problem for me. Could be a new core PTransform in core or extension. Regards JB Le 20 févr. 2018 à 11:17, à 11:17, Romain Manni-Bucau a écrit: >Yep, idea is to encapsulate the transfo. Today if you dev a dofn you >are >enforced to do a ptransform to force the coder which is a

Re: force the coder for a pardo

2018-02-20 Thread Romain Manni-Bucau
Yep, idea is to encapsulate the transfo. Today if you dev a dofn you are enforced to do a ptransform to force the coder which is a bit overkill in general. Being able to do it on the pardo would increase the composability on the user side and reduce the boilerplate needed for that. public class My

Re: force the coder for a pardo

2018-02-20 Thread Jean-Baptiste Onofré
Not on the PCollection ? Only ParDo ? Le 20 févr. 2018 à 10:50, à 10:50, Romain Manni-Bucau a écrit: >Hi guys, > >any objection to allow to pass with the pardo a coder? Idea is to avoid >to >have to write your own transform to be able to configure the coder when >you >start from a dofn and just

force the coder for a pardo

2018-02-20 Thread Romain Manni-Bucau
Hi guys, any objection to allow to pass with the pardo a coder? Idea is to avoid to have to write your own transform to be able to configure the coder when you start from a dofn and just do something like ParDo.of(new MyFn(), new MyCoder()) which is directly integrable into a pipeline properly.