Re: possible bug in AvroUtils

2020-05-01 Thread Brian Hulette
Let's discuss details on the jira. I could maybe take it, but could use advice on the right course of action. On Fri, May 1, 2020 at 6:05 AM Ismaël Mejía wrote: > I dug deeper and found that this global static change was introduced > since the beginning of the Avro / Beam Schema support (Beam 2.

Re: possible bug in AvroUtils

2020-05-01 Thread Ismaël Mejía
I dug deeper and found that this global static change was introduced since the beginning of the Avro / Beam Schema support (Beam 2.15.0): https://github.com/apache/beam/commit/2a40c576cfb On Thu, Apr 30, 2020 at 8:52 PM Ismaël Mejía wrote: > > Created https://issues.apache.org/jira/browse/BEAM-

Re: possible bug in AvroUtils

2020-04-30 Thread Ismaël Mejía
Created https://issues.apache.org/jira/browse/BEAM-9863 to track this. Any taker? On Thu, Apr 30, 2020 at 5:54 PM Reuven Lax wrote: > > I'm not sure who added that, but it's been there for a while. Making global > static changes like that in our module seems like poor form - I wonder if > there

Re: possible bug in AvroUtils

2020-04-30 Thread Reuven Lax
I'm not sure who added that, but it's been there for a while. Making global static changes like that in our module seems like poor form - I wonder if there's a better approach. On Thu, Apr 30, 2020 at 8:36 AM Brian Hulette wrote: > It seems likely this is a side effect of some static initializat

Re: possible bug in AvroUtils

2020-04-30 Thread Brian Hulette
It seems likely this is a side effect of some static initialization in AvroUtils: https://github.com/apache/beam/blob/763b7ccd17a420eb634d6799adcd3ecfcf33d6a7/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/AvroUtils.java#L99 On Wed, Apr 29, 2020 at 9:59 PM Reuven Lax wrote: > I'v

Re: possible bug in AvroUtils

2020-04-29 Thread Reuven Lax
I've copied this failing test into my client, and it passes for me. I can't reproduce the failure. On Wed, Apr 29, 2020 at 6:34 PM Luke Cwik wrote: > +dev +Brian Hulette +Reuven > Lax > > On Wed, Apr 29, 2020 at 4:21 AM Paolo Tomeo wrote: > >> Hi all, >> >> I think the method AvroUtils.toBea

Re: possible bug in AvroUtils

2020-04-29 Thread Luke Cwik
+dev +Brian Hulette +Reuven Lax On Wed, Apr 29, 2020 at 4:21 AM Paolo Tomeo wrote: > Hi all, > > I think the method AvroUtils.toBeamSchema has a not expected side effect. > I found out that, if you invoke it and then you run a pipeline of > GenericRecords containing a timestamp (l tried with