Re: KafkaIO Windowing Fn

The default implementation returns processing timestamp of the last record (in effect. more accurately it returns same as getTimestamp(), which might overridden by user). As a work around, yes, you can provide your own watermarkFn that essentially returns Now() or Now()-1sec. (usage in javadoc

Re: Remove legacy import-order?

Done as of #829. Thanks Ben, for simplifying our imports and getting rid of our legacy dependence on Google's import structure. On Wed, Aug 24, 2016 at 10:04 AM, Mark Liu wrote: > +1 for reformatting import order. > > On Wed, Aug 24, 2016 at 9:17 AM, Lukasz Cwik

KafkaIO Windowing Fn

Hi All I am trying to do some simple batch processing on KafkaIO records. My beam pipeline looks like following: pipeline.apply(KafkaIO.read() .withTopics(ImmutableList.of(s"mytopic")) .withBootstrapServers("localhost:9200") .apply("ExtractMessage", ParDo.of(new

Re: Remove legacy import-order?

+1 for reformatting import order. On Wed, Aug 24, 2016 at 9:17 AM, Lukasz Cwik wrote: > +1 for import order > > On Wed, Aug 24, 2016 at 9:01 AM, Amit Sela wrote: > > > +1 on import order as well. > > Kenneth has a good point about history if we

Re: Remove legacy import-order?

+1 for import order On Wed, Aug 24, 2016 at 9:01 AM, Amit Sela wrote: > +1 on import order as well. > Kenneth has a good point about history if we reformat. > > On Wed, Aug 24, 2016, 18:59 Kenneth Knowles > wrote: > > > +1 to import order > > > >

Re: Remove legacy import-order?

+1 on import order as well. Kenneth has a good point about history if we reformat. On Wed, Aug 24, 2016, 18:59 Kenneth Knowles wrote: > +1 to import order > > I don't care about actually enforcing formatting, but would add it to IDE > tips and just make it an "OK topic

Re: Remove legacy import-order?

+1 to import order I don't care about actually enforcing formatting, but would add it to IDE tips and just make it an "OK topic for code review". Enforcing it would result in obscuring a lot of history for who to talk to about pieces of code. And by the way there is a recent build of the

Re: Configuring IntelliJ to enforce checkstyle rules

Nice step-by-step. +1 to adding tips for particular IDEs in the contribution guide. On Wed, Aug 24, 2016 at 7:48 AM, Jean-Baptiste Onofré wrote: > Hi Stas, > > Thanks for sharing ! > > As discussed with Amit on Hangout (and indirectly with you ;)), it's what > I'm using in

Re: Configuring IntelliJ to enforce checkstyle rules

Hi Stas, Thanks for sharing ! As discussed with Amit on Hangout (and indirectly with you ;)), it's what I'm using in my config. Some stuff that I added on IntelliJ: - in Editor -> Code Style -> Java -> Tabs and Indents, I disabled "Use tab character", and defined 2 for "Tab Size" and

Configuring IntelliJ to enforce checkstyle rules

Hi guys, Having IntelliJ enforce Beam's Checkstyle rules turned out to be very useful for me, so I figured I'd share the steps just in case. 1. Install the Checkstyle plugin 1. Select the *Plugins* menu from the *Preferences* (Cmd+",") 2. Click "*Browse Repositories*" 3.

Re: Remove legacy import-order?

+1 on the import order +1 on also starting a discussion about enforced formatting On Wed, 24 Aug 2016 at 06:43 Jean-Baptiste Onofré wrote: > Agreed. > > It makes sense for the import order. > > Regards > JB > > On 08/24/2016 02:32 AM, Ben Chambers wrote: > > I think