Re: [DISCUSS] PTransform.named vs. named apply

2016-06-23 Thread Dan Halperin
A little late... but yes! +1 On Wed, Jun 22, 2016 at 11:13 PM, Aljoscha Krettek wrote: > ±1 for the named apply > > On Thu, Jun 23, 2016, 07:07 Robert Bradshaw > wrote: > > > +1, I think it makes more sense to name the application of a

Re: [DISCUSS] PTransform.named vs. named apply

2016-06-23 Thread Ben Chambers
FYI: Created https://issues.apache.org/jira/browse/BEAM-370 to track changes made in this direction. On Wed, Jun 22, 2016 at 11:13 PM Aljoscha Krettek wrote: > ±1 for the named apply > > On Thu, Jun 23, 2016, 07:07 Robert Bradshaw > wrote: > >

Re: [DISCUSS] PTransform.named vs. named apply

2016-06-23 Thread Aljoscha Krettek
±1 for the named apply On Thu, Jun 23, 2016, 07:07 Robert Bradshaw wrote: > +1, I think it makes more sense to name the application of a transform > rather than the transform itself. (Still mulling on how best to do > this with Python...) > > On Wed, Jun 22, 2016 at

Re: [DISCUSS] PTransform.named vs. named apply

2016-06-22 Thread Amit Sela
+1 On Thu, Jun 23, 2016 at 7:27 AM Jean-Baptiste Onofré wrote: > +1 > > Regards > JB > > On 06/23/2016 12:17 AM, Ben Chambers wrote: > > Based on a recent PR (https://github.com/apache/incubator-beam/pull/468) > I > > was reminded of the confusion around the use of > >

Re: [DISCUSS] PTransform.named vs. named apply

2016-06-22 Thread Jean-Baptiste Onofré
+1 Regards JB On 06/23/2016 12:17 AM, Ben Chambers wrote: Based on a recent PR (https://github.com/apache/incubator-beam/pull/468) I was reminded of the confusion around the use of .apply(transform.named(someName)) and .apply(someName, transform). This is one of things I’ve wanted to cleanup

Re: [DISCUSS] PTransform.named vs. named apply

2016-06-22 Thread Lukasz Cwik
+1 on your proposed solution On Wed, Jun 22, 2016 at 3:17 PM, Ben Chambers wrote: > Based on a recent PR (https://github.com/apache/incubator-beam/pull/468) I > was reminded of the confusion around the use of > .apply(transform.named(someName)) and .apply(someName,