Re: Committer workflow

2016-03-21 Thread Amit Sela
+1 for knowledge-sharing and getting to know other pieces of our code base. I would definitely be interested in getting to know Beam better, apart from the parts a runner developer deals with. On Mon, Mar 21, 2016, 20:19 Kenneth Knowles wrote: > +1 for emphasizing the knowledge-sharing aspect of

Re: Committer workflow

2016-03-21 Thread Kenneth Knowles
+1 for emphasizing the knowledge-sharing aspect of review. I think it is the most important for project health, and the most fun too! I love the chance to learn about a new piece of code (or learn how I messed up in my own code :-)​

Re: Committer workflow

2016-03-21 Thread Frances Perry
I'd like to suggest a slightly stronger review process. In the draft guidelines it currently says all PRs should get reviewed, regardless of author. The only real exception to that is something that is an emergency f

Re: Committer workflow

2016-03-21 Thread Jean-Baptiste Onofré
+1 The key part is the fact that a reviewer (different from the author) has to put a comment LGTM (Looks Good To Me) in the PR. With this, the reviewer or the author can push the change. Thanks Frances ! Regards JB On 03/21/2016 05:53 PM, Frances Perry wrote: I'd like to suggest a slightly

Re: Committer workflow

2016-03-21 Thread Jean-Baptiste Onofré
Hi Max, fully agree, my previous e-mail was more my own mea culpa as I pushed a change without PR (of course it was minor change as it concerned the legal NOTICE and DISCLAINER files ;)). So, my intend was just a global reminder, including myself ;) Regards JB On 03/21/2016 10:50 AM, Maximi

Re: Committer workflow

2016-03-21 Thread Maximilian Michels
Hi JB, If I remember correctly from the past discussions, we agreed that we want a PR-review process for all code changes which are important/major or break the API in some way. I wholeheartedly agree with this process. In addition, committers preserve the right to provide small fixes which do no

Committer workflow

2016-03-20 Thread Jean-Baptiste Onofré
Hi all, As a reminder, we agreed that everyone in the project should use the same workflow: prepare a PR, submit the PR, give some time to review, apply the PR. Right now, we had some pushes directly without a PR. It would be great to we *all* use the same workflow. Thanks ! Regards JB --