Re: add component tag to pull request title / commit comment

2016-05-12 Thread Maximilian Michels
@Aljoscha: Yes, less space for the commit message if it has to fit into 70 chars. I'm not sure how important a 70 character limit is nowadays. @Davor I think your observation is correct. In Flink we also like to do tagged commits but enforcing it is almost impossible. Automatic tagging would be

Re: add component tag to pull request title / commit comment

2016-05-11 Thread Aljoscha Krettek
This will, however, also take precious space in the Commit Title. And some commits might not be about only one clear-cut component. On Wed, 11 May 2016 at 11:43 Maximilian Michels wrote: > +1 I think it makes it easier to see at a glance to which part of Beam > a commit

Re: add component tag to pull request title / commit comment

2016-05-11 Thread Jean-Baptiste Onofré
Hi Manu, good idea. Theoretically the component in the corresponding Jira should give the information, but for convenience, we could add a "tag" in the commit comment. Regards JB On 05/10/2016 06:27 AM, Manu Zhang wrote: Guys, As I've been developing Gearpump runner for Beam, I've closely

add component tag to pull request title / commit comment

2016-05-09 Thread Manu Zhang
Guys, As I've been developing Gearpump runner for Beam, I've closely watched the pull requests updates for API changes. Sometimes, it turns out changes are only to be applied to a specific runner after I go through the codes. Could we add a tag in the pull request title / commit comment to mark