Github user rvs commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/193#discussion_r121272401
--- Diff: bigtop-tests/smoke-tests/run_itest.sh ---
@@ -262,16 +326,23 @@ echo "# Use --debug/--info for more details"
if [ -z "$
Github user rvs commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/193#discussion_r121272384
--- Diff:
bigtop-tests/smoke-tests/odpi-runtime/src/test/groovy/org/odpi/specs/runtime/TestSpecsRuntime.groovy
---
@@ -239,6 +239,34 @@ public class
Github user rvs commented on the issue:
https://github.com/apache/bigtop/pull/234
@sekikn I think the patch looks reasonable, @oflebbe did you mistype? This
patch only applies on Debian side -- so if you know any caveats of using
--ingroup on that platform -- please let us know
Github user rvs commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/193#discussion_r110058076
--- Diff:
bigtop-tests/smoke-tests/odpi-runtime/src/test/groovy/org/odpi/specs/runtime/TestSpecsRuntime.groovy
---
@@ -239,6 +239,34 @@ public class
Github user rvs commented on the issue:
https://github.com/apache/bigtop/pull/193
Sorry -- trigger happy fingers. What I means is: could you please submit a
JIRA against Bigtop as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rvs commented on the issue:
https://github.com/apache/bigtop/pull/193
@rajddesai since the release has happened can you submit this against
Bigtop?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rvs commented on the issue:
https://github.com/apache/bigtop/pull/175
LGTM! Please commit ASAP!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rvs commented on the issue:
https://github.com/apache/bigtop/pull/191
LGTM! Please commit ASAP!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rvs commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/188#discussion_r108095450
--- Diff: bigtop-packages/src/common/apex/do-component-build ---
@@ -26,10 +26,10 @@ command -v mvn > /dev/null 2>&1 || {
}
# Build ape
Github user rvs commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/188#discussion_r107508942
--- Diff: bigtop-packages/src/common/apex/do-component-build ---
@@ -28,6 +28,9 @@ command -v mvn > /dev/null 2>&1 || {
# Build apex
mvn cle
GitHub user rvs opened a pull request:
https://github.com/apache/bigtop/pull/159
ODPI-185 and ODPI-199
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rvs/bigtop odpi-master
Alternatively you can review and apply these
Github user rvs closed the pull request at:
https://github.com/apache/bigtop/pull/159
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rvs commented on the issue:
https://github.com/apache/bigtop/pull/141
LGTM! (aside from the formatting fix). Olaf taking a look would be great,
but I think it is small enough so we can just go ahead and commit it.
---
If your project is set up for it, you can reply to
Github user rvs commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/132#discussion_r71269745
--- Diff: bigtop-packages/src/rpm/flink/SPECS/flink.spec ---
@@ -53,6 +54,14 @@ Source6: bigtop.bom
Requires: bigtop-utils >= 0.7
Requires(preun): /s
Github user rvs commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/132#discussion_r71269543
--- Diff: bigtop-packages/src/rpm/flink/SPECS/flink.spec ---
@@ -106,29 +134,17 @@ bash $RPM_SOURCE_DIR/do-component-build
sh -x %{SOURCE2} --prefix
Github user rvs commented on the issue:
https://github.com/apache/bigtop/pull/133
@amit-altiscale this is a huge diff, can you please let us know (pref. via
JIRA) what is it you're trying to achieve?
---
If your project is set up for it, you can reply to this email and have
Github user rvs commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/132#discussion_r70703555
--- Diff: bigtop-packages/src/rpm/flink/SPECS/flink.spec ---
@@ -72,19 +81,38 @@ Some of the key features of Apache Flink includes.
* Fault-tolerance via
Github user rvs commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/132#discussion_r70702844
--- Diff: bigtop-packages/src/deb/flink/flink-jobmanager.postinst ---
@@ -0,0 +1,33 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation
Github user rvs commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/132#discussion_r70702283
--- Diff: bigtop-packages/src/deb/flink/control ---
@@ -27,3 +27,13 @@ Depends: bigtop-utils (>= 0.7), adduser
Description: Flinkâs core is a stream
Github user rvs commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/132#discussion_r70702252
--- Diff: bigtop-packages/src/deb/flink/control ---
@@ -27,3 +27,13 @@ Depends: bigtop-utils (>= 0.7), adduser
Description: Flinkâs core is a stream
Github user rvs commented on the issue:
https://github.com/apache/bigtop/pull/130
Hi @lucasa first of all, thanks a million for the patch. Also, I think this
has to be fixed on the build side rather than on the deployment side. In fact,
it looks like a few things need to be fixed on
Github user rvs commented on the issue:
https://github.com/apache/bigtop/pull/111
Great! If nobody has any other concerns -- I'll be merging it in tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user rvs commented on the issue:
https://github.com/apache/bigtop/pull/122
This looks good as a very, very basic ZK test. See the small nit I had tho.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rvs commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/122#discussion_r67440497
--- Diff: bigtop-tests/smoke-tests/zookeeper/TestZookeeper.groovy ---
@@ -0,0 +1,66 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user rvs commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/111#discussion_r67066106
--- Diff: bigtop-deploy/vm/vagrant-puppet-vm/Vagrantfile ---
@@ -112,7 +113,7 @@ Vagrant.configure(VAGRANTFILE_API_VERSION) do |config
Github user rvs commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/111#discussion_r67065894
--- Diff: bigtop-deploy/puppet/modules/flink/manifests/init.pp ---
@@ -0,0 +1,64 @@
+# The ASF licenses this file to You under the Apache License, Version 2.0
Github user rvs commented on the issue:
https://github.com/apache/bigtop/pull/111
Will definitely take a look over the weekend once I'm back in US.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
27 matches
Mail list logo
