Github user evans-ye commented on the issue:
https://github.com/apache/bigtop/pull/370
@bharatm363 sorry to answer back late. I was on a week long vacation ;)
I know there's a squash button in Github, however since github is just only
a mirror of Bigtop codebase, we don't use it
Github user evans-ye commented on the issue:
https://github.com/apache/bigtop/pull/370
Aside the code, another thing we need to do is to squash all the commits
into one commit.
See here:
Github user bharatm363 commented on the issue:
https://github.com/apache/bigtop/pull/370
@evans-ye Uploading some changes now, the main thing that I didn't directly
address were the sql calls which are still performed in a large group. I
thought that would be better as they all test
Github user evans-ye commented on the issue:
https://github.com/apache/bigtop/pull/370
@bharatm363 can we have this in 1.3?
---
Github user evans-ye commented on the issue:
https://github.com/apache/bigtop/pull/370
Sure. Just want to let you know that it doesn't mean that everything I
comment need to be addressed. If you think I'm wrong, reply with your thought.
---
Github user bharatm363 commented on the issue:
https://github.com/apache/bigtop/pull/370
Thanks for the comments, I'll look into these, I'm going to refactor it
some to make everything more readable and address some of the points you raised
above. @evans-ye
---
Github user bharatm363 commented on the issue:
https://github.com/apache/bigtop/pull/370
@evans-ye I have created an issue on JIRA for this testing,
https://issues.apache.org/jira/browse/BIGTOP-3049, please let me know if that
is correct.
---
Github user bharatm363 commented on the issue:
https://github.com/apache/bigtop/pull/370
Sure @evans-ye, how can I go about doing that on
https://issues.apache.org/jira/projects/BIGTOP/issues
---
Github user evans-ye commented on the issue:
https://github.com/apache/bigtop/pull/370
Hi @bharatm363 can you create a JIRA on BIGTOP and describe what feature
you'd like to add?
---
