Re: Code freeze for apache bookkeeper 4.6.0 release

2017-11-03 Thread Sijie Guo
lgtm +1 well done, Jia! - Sijie On Fri, Nov 3, 2017 at 5:37 PM, Jia Zhai wrote: > Hi all, > Updating, FYI: > The new milestone and labels for 4.7.0, and release branch-4.6 have been > created: > https://github.com/apache/bookkeeper/labels/release%2F4.7.0 > https://github.com/apache/bookkeeper/

Re: Code freeze for apache bookkeeper 4.6.0 release

2017-11-03 Thread Jia Zhai
Hi all, Updating, FYI: The new milestone and labels for 4.7.0, and release branch-4.6 have been created: https://github.com/apache/bookkeeper/labels/release%2F4.7.0 https://github.com/apache/bookkeeper/milestone/3 https://github.com/apache/bookkeeper/tree/branch-4.6 I will go through the opened 4.

Re: bookkeeper dist package

2017-11-03 Thread Enrico Olivelli
Il ven 3 nov 2017, 18:17 Sijie Guo ha scritto: > On Thu, Nov 2, 2017 at 2:26 AM, Enrico Olivelli > wrote: > > > 2017-11-02 10:11 GMT+01:00 Sijie Guo : > > > > > On Thu, Nov 2, 2017 at 12:44 AM, Enrico Olivelli > > > wrote: > > > > > > > 2017-11-02 8:34 GMT+01:00 Sijie Guo : > > > > > > > > > Hi

Re: Iterable

2017-11-03 Thread Sijie Guo
On Thu, Nov 2, 2017 at 10:49 PM, Enrico Olivelli wrote: > > > Il ven 3 nov 2017, 02:39 Sijie Guo ha scritto: > >> Hi Enrico, >> >> In the new ledger api, we return Iterable instead of >> Iterator. In general, it is good to return Iterable, however >> it seems to be problematic in following use c

Re: bookkeeper dist package

2017-11-03 Thread Sijie Guo
On Thu, Nov 2, 2017 at 2:26 AM, Enrico Olivelli wrote: > 2017-11-02 10:11 GMT+01:00 Sijie Guo : > > > On Thu, Nov 2, 2017 at 12:44 AM, Enrico Olivelli > > wrote: > > > > > 2017-11-02 8:34 GMT+01:00 Sijie Guo : > > > > > > > Hi all, > > > > > > > > in apache/bookkeeper#499

Re: Cutting 4.5.1 release

2017-11-03 Thread Enrico Olivelli
Another showstopper for 4.5.1 (and 4.6.0), I think we have to update NOTICE file for bookkeeper-dist package https://github.com/apache/bookkeeper/issues/688 Enrico 2017-11-02 23:16 GMT+01:00 Ivan Kelly : > > I wonder if I should create a pull request in order to bump the > > 4.5.1-SNAPSHOT and

Re: Cutting 4.5.1 release

2017-11-03 Thread Enrico Olivelli
Another showstopper for 4.5.1 (and 4.6.0), I think we have to update NOTICE file for bookkeeper-dist package https://github.com/apache/bookkeeper/issues/688 Enrico 2017-11-02 23:16 GMT+01:00 Ivan Kelly : > > I wonder if I should create a pull request in order to bump the > > 4.5.1-SNAPSHOT and