Re: [VOTE] Release 4.15.0, release candidate #0

2022-04-01 Thread Hang Chen
Hi Andrey, I download the source code and build it by multi cpu cores, it failed occasionally. I opened an issue to track it. https://github.com/apache/bookkeeper/issues/3174 It maybe an old issue, and it is not the blocker for this release. Thanks, Hang Andrey Yegorov 于2022年4月1日周五

Re: [VOTE] Release 4.15.0, release candidate #0

2022-04-01 Thread Andrey Yegorov
ok, please cherry-pick or label PRs to cherry-pick into the release, we'll have to go through RC1. I tried upgrading Pulsar and enountered breaking changes listed here: https://github.com/apache/bookkeeper/pull/3155/files#diff-eff52edf7022fd953f60c68061de09ec5d148eb37893de6af85a7964a2e57855 I'll

Re: BookKeeper 4.14.5 - drop Log4J and move to Reload4J?

2022-04-01 Thread ZhangJian He
+1 agree with Nicolò Thanks ZhangJian He Nicolò Boschi 于2022年4月1日周五 21:20写道: > Enrico, I agree with you and that was what I meant. > > To be clear: > 4.14.3 and older: Log4J 1 > 4.14.5 and 4.14.6...: Reload4J > 4.15.0 and next: Log4J2 > > Nicolò Boschi > > > Il giorno ven 1 apr 2022 alle ore

Re: BookKeeper 4.14.5 - drop Log4J and move to Reload4J?

2022-04-01 Thread Nicolò Boschi
Enrico, I agree with you and that was what I meant. To be clear: 4.14.3 and older: Log4J 1 4.14.5 and 4.14.6...: Reload4J 4.15.0 and next: Log4J2 Nicolò Boschi Il giorno ven 1 apr 2022 alle ore 14:51 Enrico Olivelli ha scritto: > I prefer Log4J2, Reload4J is really a hack to have Log41

Revert RocksDB upgrade on BookKeeper branch 4.14?

2022-04-01 Thread Nicolò Boschi
Hi all, this is a follow-up discussion about the RocksDB upgrade that happened at yesterday's Apache Pulsar community meeting ( https://lists.apache.org/thread/tq7dsws72zf9r7qzr4l567z9w346ksbm). We're going to release BookKeeper 4.14.5 in the next few days and there is a decision to make about

Re: BookKeeper 4.14.5 - drop Log4J and move to Reload4J?

2022-04-01 Thread Enrico Olivelli
I prefer Log4J2, Reload4J is really a hack to have Log41 compatibility (and it is not 100% compatible) Log4j1 has many problems, and this is why Apache Logging started a brand new project. It is okay to use Reload4J on old branches in which we cannot break compatibility, but for new releases we

BookKeeper 4.14.5 - drop Log4J and move to Reload4J?

2022-04-01 Thread Nicolò Boschi
Hi all, A couple of months ago we removed the usage of Log4J in favor of Log4J2 ( https://github.com/apache/bookkeeper/pull/2816). These changes have only been done for the master branch (and actually 4.15.0) We're still bundling Log4J for the 4.14 line. I propose to move to Reload4J

Re: [VOTE] Release 4.15.0, release candidate #0

2022-04-01 Thread Enrico Olivelli
-1 I have run the tests and a few smoke tests and everything is passing. But unfortunately the Bookie is not logging anymore due to the switch to log4j2 I have tracked the problem here https://github.com/apache/bookkeeper/issues/3165 Not blocker for a release: I should also note that upgrading

Re: Cutting a release out of branch-4.14

2022-04-01 Thread Enrico Olivelli
Il Ven 1 Apr 2022, 03:41 Yong Zhang ha scritto: > Thank you very much! > > Another question about the cherry-pick is, does the cherry-pick step > always handled by who merged the PR? And when a bug fix is merged, > looks like we rarely label to mark release to some minor version? > You can